Title: [114814] trunk/Source/WebCore
- Revision
- 114814
- Author
- [email protected]
- Date
- 2012-04-20 18:02:51 -0700 (Fri, 20 Apr 2012)
Log Message
[chromium] Tiny change to DomStorage v8 bindings to avoid a relatively expensive test in a couple
of places by reordering the expressions in compound conditions, if (fastTest && moreExpensiveTest)
https://bugs.webkit.org/show_bug.cgi?id=84500
Reviewed by Kentaro Hara.
No new tests, no new functionality.
* bindings/v8/custom/V8StorageCustom.cpp:
(WebCore::storageGetter):
(WebCore::V8Storage::namedPropertyQuery):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (114813 => 114814)
--- trunk/Source/WebCore/ChangeLog 2012-04-21 00:58:49 UTC (rev 114813)
+++ trunk/Source/WebCore/ChangeLog 2012-04-21 01:02:51 UTC (rev 114814)
@@ -1,3 +1,17 @@
+2012-04-20 Michael Nordman <[email protected]>
+
+ [chromium] Tiny change to DomStorage v8 bindings to avoid a relatively expensive test in a couple
+ of places by reordering the expressions in compound conditions, if (fastTest && moreExpensiveTest)
+ https://bugs.webkit.org/show_bug.cgi?id=84500
+
+ Reviewed by Kentaro Hara.
+
+ No new tests, no new functionality.
+
+ * bindings/v8/custom/V8StorageCustom.cpp:
+ (WebCore::storageGetter):
+ (WebCore::V8Storage::namedPropertyQuery):
+
2012-04-20 Dan Bernstein <[email protected]>
REGRESSION (r114784): svg/text/foreignObject-text-clipping-bug.xml failing on Mountain Lion Debug Tests
Modified: trunk/Source/WebCore/bindings/v8/custom/V8StorageCustom.cpp (114813 => 114814)
--- trunk/Source/WebCore/bindings/v8/custom/V8StorageCustom.cpp 2012-04-21 00:58:49 UTC (rev 114813)
+++ trunk/Source/WebCore/bindings/v8/custom/V8StorageCustom.cpp 2012-04-21 01:02:51 UTC (rev 114814)
@@ -58,7 +58,7 @@
Storage* storage = V8Storage::toNative(info.Holder());
String name = toWebCoreString(v8Name);
- if (storage->contains(name) && name != "length")
+ if (name != "length" && storage->contains(name))
return v8String(storage->getItem(name));
return notHandledByInterceptor();
@@ -86,7 +86,7 @@
Storage* storage = V8Storage::toNative(info.Holder());
String name = toWebCoreString(v8Name);
- if (storage->contains(name) && name != "length")
+ if (name != "length" && storage->contains(name))
return v8::Integer::New(v8::None);
return v8::Handle<v8::Integer>();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
