Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3758cfaf08eb56e69ac1344a9e456c61b55af639
https://github.com/WebKit/WebKit/commit/3758cfaf08eb56e69ac1344a9e456c61b55af639
Author: Tyler Wilcock <[email protected]>
Date: 2026-05-12 (Tue, 12 May 2026)
Changed paths:
M Source/WebCore/accessibility/AXCoreObject.cpp
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/AXLogger.cpp
M Source/WebCore/accessibility/AccessibilityObject.cpp
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp
M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h
M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
Log Message:
-----------
AX: Represent popup value as an enum to avoid string allocation in hasPopup()
https://bugs.webkit.org/show_bug.cgi?id=314605
rdar://176848676
Reviewed by Dominic Mazzoni.
Replace String-returning popupValue() / explicitPopupValue() with a single
virtual popupValue() returning AccessibilityPopupValue (uint8_t enum).
hasPopup() becomes an inline enum comparison with zero allocation.
This string allocation showed up in samples taken while using VoiceOver
on a webpage.
Platform callers (iOS, Mac, ATSPI) now use popupValueString(), which converts
the enum to a static ASCIILiteral at the API boundary. The isolated tree caches
the enum as an int rather than a String.
* Source/WebCore/accessibility/AXCoreObject.cpp:
(WebCore::AXCoreObject::popupValueString const):
(WebCore::AXCoreObject::popupValue const): Deleted.
(WebCore::AXCoreObject::hasPopup const): Deleted.
* Source/WebCore/accessibility/AXCoreObject.h:
(WebCore::AXCoreObject::hasPopup const):
* Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::operator<<):
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::popupValue const):
(WebCore::AccessibilityObject::explicitPopupValue const): Deleted.
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::attributes const):
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityPopupValue]):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::createIsolatedObjectData):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(handlePopupValueAttribute):
Canonical link: https://commits.webkit.org/313102@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
