Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4d111a1453f2912a320d2cc7b2a6a302074ab3b6
      
https://github.com/WebKit/WebKit/commit/4d111a1453f2912a320d2cc7b2a6a302074ab3b6
  Author: Kiet Ho <[email protected]>
  Date:   2026-05-12 (Tue, 12 May 2026)

  Changed paths:
    M LayoutTests/fast/loader/onload-willSendRequest-null-for-frame.html

  Log Message:
  -----------
  [Site Isolation] fast/loader/onload-willSendRequest-null-for-frame.html loads 
an external URL iframe that gets blocked
rdar://176497077
https://bugs.webkit.org/show_bug.cgi?id=314346

Reviewed by Ryosuke Niwa.

fast/loader/onload-willSendRequest-null-for-frame.html loads an iframe from an 
external
URL (http://example.com). In Site Isolation mode, this gets blocked by
TestController::decidePolicyForNavigationAction. This has two effects:

1) the test page never reaches InjectedBundlePage::willSendRequestForFrame(), 
so it can't
   test that onload fires when willSendRequestForFrame() returns null
2) TestController::decidePolicyForNavigationAction prints "Blocked access to 
external URL..."
   when the URL is blocked. This only occurs when Site Isolation is enabled, 
hence the output
   will be different compared to Site Isolation disabled.

Fix this by changing the iframe URL to a local page. I manually confirm that
InjectedBundlePage::willSendRequestForFrame() is still reached and returns null 
in SI-off and SI-on.

* LayoutTests/fast/loader/onload-willSendRequest-null-for-frame.html:

Canonical link: https://commits.webkit.org/313105@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to