Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: db77dc012d212bfe7d28b0f594b4f385b2751cf3
https://github.com/WebKit/WebKit/commit/db77dc012d212bfe7d28b0f594b4f385b2751cf3
Author: Brady Eidson <[email protected]>
Date: 2026-05-12 (Tue, 12 May 2026)
Changed paths:
M Source/WebCore/platform/gamepad/cocoa/GameControllerGamepad.mm
M Source/WebCore/platform/gamepad/mac/LogitechGamepad.cpp
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/mac/HIDGamepads.mm
Log Message:
-----------
Extended gamepads should always have extended gamepad layout, even if home
button is absent
rdar://176585914
https://bugs.webkit.org/show_bug.cgi?id=314649
Reviewed by Chris Dumez.
GameController framework will present an extended gamepad - that matches up
with the 17 button web standard for "extended gamepad",
for controllers that physically only have 16 buttons.
We failed to present the 17th button (home button) to web content in this case,
even if it can never be pressed.
Let's do so.
Test: Tools/TestWebKitAPI/Tests/WebKit/WKWebView/mac/HIDGamepads.mm
* Source/WebCore/platform/gamepad/cocoa/GameControllerGamepad.mm:
(WebCore::GameControllerGamepad::setupElements):
* Source/WebCore/platform/gamepad/mac/LogitechGamepad.cpp:
(WebCore::LogitechGamepad::LogitechGamepad):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/mac/HIDGamepads.mm:
(TestWebKitAPI::(Gamepad, LogitechBasic)):
Canonical link: https://commits.webkit.org/313119@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
