Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 607c5eb1527c31876ab6e916da9a19a6aba399f0
https://github.com/WebKit/WebKit/commit/607c5eb1527c31876ab6e916da9a19a6aba399f0
Author: Chris Dumez <[email protected]>
Date: 2026-05-12 (Tue, 12 May 2026)
Changed paths:
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKBackForwardListTests.mm
Log Message:
-----------
[macOS Debug]
TestWebKitAPI.WKBackForwardList.BackForwardNavigationSkipsItemsWithoutUserGestureFragment
is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=313844
rdar://176046782
Reviewed by Brady Eidson.
The test was disabled on macOS due to flaky timeouts on Intel Debug builds. The
delegate's waitForDidFinishNavigationOrDidSameDocumentNavigation only wakes on
didFinishNavigation or SessionStatePush/SessionStatePop. If anything upstream
causes that signal to be skipped for one of the same-document navigations in
the test (for example, Navigation API's innerDispatchNavigateEvent returning
DispatchResult::Aborted), no signal ever fires and the wait hangs until the
test-framework timeout with no actionable diagnostic.
Re-enable the test on macOS and add a finite-timeout variant of the delegate
wait used by this test. The helper now bails out at the first wait that
doesn't fire within 10 seconds, logging the navigation step that stalled and
the current webView.URL, and records an EXPECT failure. A rare underlying
navigation hang therefore surfaces as a fast, localized failure with context,
rather than as a silent timeout, making the next investigation of the
underlying Navigation API race tractable.
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKBackForwardListTests.mm:
(-[WKBackForwardNavigationDelegate
waitForDidFinishNavigationOrDidSameDocumentNavigationWithTimeout:]):
(runBackForwardNavigationSkipsItemsWithoutUserGestureTest):
(TEST(WKBackForwardList,
BackForwardNavigationSkipsItemsWithoutUserGestureFragment)):
Canonical link: https://commits.webkit.org/313126@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
