Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4f9b47c98b3a1486c04899e82c4b2809bd412a0f
https://github.com/WebKit/WebKit/commit/4f9b47c98b3a1486c04899e82c4b2809bd412a0f
Author: Adrian Taylor <[email protected]>
Date: 2026-05-13 (Wed, 13 May 2026)
Changed paths:
M Tools/Scripts/swift/swiftc-wrapper.sh
Log Message:
-----------
[Swift GTK] Remove Swift warnings from definitions with values
https://bugs.webkit.org/show_bug.cgi?id=314407
Reviewed by Richard Robinson.
Various parts of WebKit's cmake configuration accumulate various -DX=Y
definitions, especially on non-Apple platforms where definitions may be added
by pkg-config or other external configuration mechanisms. Swift does not
support -DX=Y, so stop passing them to Swift. This removes a bunch of warnings
emitted by swiftc on these builds. We continue to pass them to Swift's embedded
clang so that it interprets headers correctly.
Alternatives considered: make all the CMake files add their definitions in a
more language-specific way. Unfortunately this doesn't really work at scale
when we want to pull in pkg-config or other externally-maintained mechanisms.
We should instead try to be robust to language-agnostic definitions.
Canonical link: https://commits.webkit.org/313188@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
