Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ea89893f4a43fa2af08eccc6952ab51ece8afae8
https://github.com/WebKit/WebKit/commit/ea89893f4a43fa2af08eccc6952ab51ece8afae8
Author: Zak Ridouh <[email protected]>
Date: 2026-05-13 (Wed, 13 May 2026)
Changed paths:
M LayoutTests/http/tests/resources/js-test-post-async.js
M LayoutTests/http/tests/resources/js-test-post.js
M LayoutTests/http/tests/resources/js-test-pre.js
M LayoutTests/resources/js-test-post-async.js
M LayoutTests/resources/js-test-post.js
M LayoutTests/resources/js-test-pre.js
M Tools/Scripts/webkitpy/style/checker.py
A Tools/Scripts/webkitpy/style/checkers/deprecated_js_test_includes.py
A
Tools/Scripts/webkitpy/style/checkers/deprecated_js_test_includes_unittest.py
M Tools/Scripts/webkitpy/style/checkers/text.py
Log Message:
-----------
[check-webkit-style] Flag deprecated js-test-pre/post/post-async.js includes
https://bugs.webkit.org/show_bug.cgi?id=314676
rdar://176924986
Reviewed by Tim Nguyen.
New tests should use LayoutTests/resources/js-test.js, which combines
the functionality of the old trio. For async tests, set
window.jsTestIsAsync = true and call finishJSTest() when done.
- Adds DeprecatedJSTestIncludesChecker, composed into TextChecker, with
unit tests. Category build/deprecated/js-test-helpers, severity 5.
- Adds a // DEPRECATED: banner to the six resource files pointing
authors at js-test.js. The LayoutTests/resources/ and
http/tests/resources/ pairs remain byte-identical as JSTestChecker
requires.
* LayoutTests/http/tests/resources/js-test-post-async.js:
* LayoutTests/http/tests/resources/js-test-post.js:
* LayoutTests/http/tests/resources/js-test-pre.js:
* LayoutTests/resources/js-test-post-async.js:
* LayoutTests/resources/js-test-post.js:
* LayoutTests/resources/js-test-pre.js:
* Tools/Scripts/webkitpy/style/checker.py:
(_all_categories):
* Tools/Scripts/webkitpy/style/checkers/deprecated_js_test_includes.py: Added.
(DeprecatedJSTestIncludesChecker):
*
Tools/Scripts/webkitpy/style/checkers/deprecated_js_test_includes_unittest.py:
Added.
(DeprecatedJSTestIncludesCheckerTest):
(DeprecatedJSTestIncludesCheckerTest._collect_errors):
(DeprecatedJSTestIncludesCheckerTest._collect_errors.record):
(DeprecatedJSTestIncludesCheckerTest.assertError):
(DeprecatedJSTestIncludesCheckerTest.assertNoError):
(DeprecatedJSTestIncludesCheckerTest.test_flags_pre_include_relative):
(DeprecatedJSTestIncludesCheckerTest.test_flags_post_include_relative):
(DeprecatedJSTestIncludesCheckerTest.test_flags_absolute_http_path):
(DeprecatedJSTestIncludesCheckerTest.test_flags_single_quoted_src):
(DeprecatedJSTestIncludesCheckerTest.test_flags_with_type_attribute):
(DeprecatedJSTestIncludesCheckerTest.test_flags_with_query_string):
(DeprecatedJSTestIncludesCheckerTest.test_reports_correct_line_number):
(DeprecatedJSTestIncludesCheckerTest.test_does_not_flag_modern_js_test):
(DeprecatedJSTestIncludesCheckerTest.test_flags_post_async):
(DeprecatedJSTestIncludesCheckerTest.test_does_not_flag_unrelated_script):
(DeprecatedJSTestIncludesCheckerTest.test_does_not_flag_plain_filename_mention):
(DeprecatedJSTestIncludesCheckerTest.test_case_insensitive_tag):
* Tools/Scripts/webkitpy/style/checkers/text.py:
(TextChecker.__init__):
(TextChecker.check):
Canonical link: https://commits.webkit.org/313204@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
