Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6bebe6dfcd60d2cc90898ef049e4e9ba8fcc8916
https://github.com/WebKit/WebKit/commit/6bebe6dfcd60d2cc90898ef049e4e9ba8fcc8916
Author: Nikolas Zimmermann <[email protected]>
Date: 2026-05-14 (Thu, 14 May 2026)
Changed paths:
M Tools/Scripts/webkitdirs.pm
M Tools/Scripts/webkitpy/port/linux_container_sdk_utils.py
Log Message:
-----------
[GTK][WPE] Always warn on wkdev-sdk container version mismatch, regardless of
auto-enter
https://bugs.webkit.org/show_bug.cgi?id=314800
Reviewed by Claudio Saavedra.
The version-mismatch warning in maybe_enter_webkit_container_sdk() previously
fired only when WEBKIT_CONTAINER_SDK_ENABLE_AUTOENTER=1, and never at all from
Perl wrappers (build-webkit, run-javascriptcore-tests, ...) because their fast-
path mirror in webkitdirs.pm short-circuited when WEBKIT_CONTAINER_SDK==1. As
a result, a developer running an outdated wkdev-sdk container without auto-enter
got no signal that their container had drifted from .wkdev-sdk-version.
Reorder the Python helper so the in-container version-mismatch check runs
before the auto-enter opt-in gate (only host-side auto-enter remains gated on
WEBKIT_CONTAINER_SDK_ENABLE_AUTOENTER and WEBKIT_CROSS_TARGET). Update the Perl
mirror so it invokes the helper when inside the container regardless of opt-in,
keeping the host-side opt-out as the only fast-path skip.
Canonical link: https://commits.webkit.org/313228@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
