Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6053a426c6d4dae46ef4eb5989d040084f0f4a47
https://github.com/WebKit/WebKit/commit/6053a426c6d4dae46ef4eb5989d040084f0f4a47
Author: Luke Warlow <[email protected]>
Date: 2026-05-14 (Thu, 14 May 2026)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-requestclose-recurse-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-requestclose-recurse.html
M Source/WebCore/html/HTMLDialogElement.cpp
M Source/WebCore/html/HTMLDialogElement.h
Log Message:
-----------
Nesting requestClose() fires multiple cancel events
https://bugs.webkit.org/show_bug.cgi?id=311741
Reviewed by Anne van Kesteren.
Adds a flag to dialog elements that is set when calling requestClose(), this
causes an early return if already set so that authors can't accidentally create
a RangeError due to looping.
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-requestclose-recurse-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-requestclose-recurse.html:
Added.
* Source/WebCore/html/HTMLDialogElement.cpp:
(WebCore::HTMLDialogElement::requestClose):
* Source/WebCore/html/HTMLDialogElement.h:
Canonical link: https://commits.webkit.org/313239@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
