Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c7342e9519e4d91f495156d713493c480779a1e1
https://github.com/WebKit/WebKit/commit/c7342e9519e4d91f495156d713493c480779a1e1
Author: Luke Warlow <[email protected]>
Date: 2026-05-14 (Thu, 14 May 2026)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-requestclose-2-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-requestclose-2.html
A
LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-requestclose-3-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-requestclose-3.html
M Source/WebCore/html/HTMLDialogElement.cpp
Log Message:
-----------
dialog.requestClose() is missing prelimanary checks
https://bugs.webkit.org/show_bug.cgi?id=311746
Reviewed by Anne van Kesteren.
This adds a check for the dialog being connected to the document and being in a
fully active document.
This matches more recent spec changes.
Tests:
imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-requestclose-2.html
imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-requestclose-3.html
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-requestclose-2-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-requestclose-2.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-requestclose-3-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-requestclose-3.html:
Added.
* Source/WebCore/html/HTMLDialogElement.cpp:
(WebCore::HTMLDialogElement::requestClose):
Canonical link: https://commits.webkit.org/313251@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
