Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9a9c868ef9d268d0ef5571f93cb620deaed05875
https://github.com/WebKit/WebKit/commit/9a9c868ef9d268d0ef5571f93cb620deaed05875
Author: Kiara Rose <[email protected]>
Date: 2026-05-14 (Thu, 14 May 2026)
Changed paths:
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKWebExtensionAPIScripting.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKWebExtensionAPITabs.mm
Log Message:
-----------
NEW TESTS(312463@main): [macOS iOS] 2 failing tests in
TestWebKitAPI.WKWebExtensionAPI (314126)
https://bugs.webkit.org/show_bug.cgi?id=314126
rdar://176303192
Reviewed by Timothy Hatcher.
A couple issues were going wrong here:
1) PortPostMessageGestureFromContentScriptIsNotPropagated was a constant
failure because a user
gesture was always active, but not because of it being propagated from the
content script. The gesture
was active because browser.action.onClicked carries one. To fix that, use
browser.test instead to
send the message to signal the background page and content script are ready.
2) For ExecuteScriptWithUserGesture, it's possible that performActionForTab
runs before the page has
fully loaded. To fix that, use browser.tabs.onUpdated to send a 'Page Ready'
message before continuing
on with the test.
Testing:
- Verified PortPostMessageGestureFromContentScriptIsNotPropagated passes
(previously 100% failure)
- Verified ExecuteScriptWithUserGesture passes with 50 iterations (previously
at least one failure)
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKWebExtensionAPIScripting.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIScripting, ExecuteScriptWithUserGesture)):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKWebExtensionAPITabs.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPITabs,
PortPostMessageGestureFromContentScriptIsNotPropagated)):
(TestWebKitAPI::TEST(WKWebExtensionAPITabs,
DISABLED_PortPostMessageGestureFromContentScriptIsNotPropagated)): Deleted.
Canonical link: https://commits.webkit.org/313262@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
