Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3fd01c58fab1a580c0187ac8280e7acbcc48e63e
https://github.com/WebKit/WebKit/commit/3fd01c58fab1a580c0187ac8280e7acbcc48e63e
Author: Vitor Roriz <[email protected]>
Date: 2026-05-14 (Thu, 14 May 2026)
Changed paths:
M LayoutTests/editing/pasteboard/cjk-line-height-expected.txt
M
LayoutTests/fast/css/getComputedStyle/computed-style-font-family-expected.txt
M
LayoutTests/fast/css/getComputedStyle/font-family-fallback-reset-expected.txt
M LayoutTests/fast/css/getComputedStyle/font-family-fallback-reset.html
M LayoutTests/fast/css/serialization-with-double-quotes-expected.txt
M LayoutTests/fast/css/serialization-with-double-quotes.html
M LayoutTests/fast/text/font-face-family-expected.txt
M LayoutTests/fast/text/font-face-family.html
M LayoutTests/fast/text/font-stretch-parse-expected.txt
M LayoutTests/fast/text/font-stretch-parse.html
M LayoutTests/fast/text/font-style-parse-expected.txt
M LayoutTests/fast/text/font-style-parse.html
M LayoutTests/fast/text/font-weight-parse-expected.txt
M LayoutTests/fast/text/font-weight-parse.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-font-loading/fontface-invalid-family.tentative-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-font-loading/fontface-invalid-family.tentative.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-computed-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-family-computed-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-family-valid-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-valid-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/font-weight-matching-installed-fonts-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/cssom/serialize-values-expected.txt
M
LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-fonts/variations/font-weight-matching-installed-fonts-expected.txt
M LayoutTests/platform/gtk/fast/css/css2-system-fonts-expected.txt
M
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-fonts/animations/system-fonts-expected.txt
M Source/WebCore/css/CSSMarkup.cpp
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKWebViewEditActions.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/mac/FontManagerTests.mm
Log Message:
-----------
Serialize multi-word font family names without quotes when possible
https://bugs.webkit.org/show_bug.cgi?id=313243
rdar://175522811
Reviewed by Elika Etemad.
Per CSS Fonts 4 [1], a <family-name> is a sequence of one or more identifiers.
shouldQuoteFontFamily checked the whole string as a single identifier token,
which always failed for multi-word names (spaces aren't valid in a single
ident). Therefore the serialization always quoted them (e.g. "FB Armada"
instead of FB Armada). Split by spaces and check each word individually.
[1] https://www.w3.org/TR/css-fonts-4/#font-family-name-syntax
* LayoutTests/editing/pasteboard/cjk-line-height-expected.txt:
* LayoutTests/fast/css/getComputedStyle/computed-style-font-family-expected.txt:
* LayoutTests/fast/css/getComputedStyle/font-family-fallback-reset-expected.txt:
* LayoutTests/fast/css/getComputedStyle/font-family-fallback-reset.html:
* LayoutTests/fast/css/serialization-with-double-quotes-expected.txt:
* LayoutTests/fast/css/serialization-with-double-quotes.html:
* LayoutTests/fast/text/font-face-family-expected.txt:
* LayoutTests/fast/text/font-face-family.html:
* LayoutTests/fast/text/font-stretch-parse-expected.txt:
* LayoutTests/fast/text/font-stretch-parse.html:
* LayoutTests/fast/text/font-style-parse-expected.txt:
* LayoutTests/fast/text/font-style-parse.html:
* LayoutTests/fast/text/font-weight-parse-expected.txt:
* LayoutTests/fast/text/font-weight-parse.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-font-loading/fontface-invalid-family.tentative-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-font-loading/fontface-invalid-family.tentative.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-computed-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-family-computed-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-family-valid-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-valid-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/font-weight-matching-installed-fonts-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/cssom/serialize-values-expected.txt:
*
LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-fonts/variations/font-weight-matching-installed-fonts-expected.txt:
* LayoutTests/platform/gtk/fast/css/css2-system-fonts-expected.txt:
*
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-fonts/animations/system-fonts-expected.txt:
* Source/WebCore/css/CSSMarkup.cpp:
(WebCore::shouldQuoteFontFamily):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKWebViewEditActions.mm:
(TestWebKitAPI::TEST(WKWebViewEditActions, SetFontFamily)):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/mac/FontManagerTests.mm:
(TestWebKitAPI::TEST(FontManagerTests, ChangeFontWithPanel)):
Canonical link: https://commits.webkit.org/313271@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
