Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: edd7a9128891559641d803177f9cc9a2390b30af
https://github.com/WebKit/WebKit/commit/edd7a9128891559641d803177f9cc9a2390b30af
Author: Sammy Gill <[email protected]>
Date: 2026-05-14 (Thu, 14 May 2026)
Changed paths:
R
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flexbox-min-height-auto-003-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flexbox-min-height-auto-003-expected.txt
R
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flexbox-min-height-auto-003-ref.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flexbox-min-height-auto-003.html
R
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flexbox-min-height-auto-004-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flexbox-min-height-auto-004-expected.txt
R
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flexbox-min-height-auto-004-ref.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flexbox-min-height-auto-004.html
Log Message:
-----------
Convert flexbox-min-height-auto-{003,004}.html from reftests to testharness.js
https://bugs.webkit.org/show_bug.cgi?id=314824
rdar://problem/177078782
Reviewed by Alan Baradlay.
These tests are checking the behavior of min-height: auto on flex items
in a column flex layout. When a flex item's computed overflow is a
scrollable value then that item has no minimum height and min-height
acts as having a value of 0.
For the cases that exercise overflow-y:scroll/auto (directly in 003,
indirectly via overflow-x in 004), this only matched when the
implementation reserved scrollbar gutter the same way for both
flex items and floats. That coupling made the tests sensitive to
scrollbar handling that is not what the section is actually trying to
verify, and failures could occur for reasons unrelated to min-height.
Convert each test to a testharness.js test that asserts the relevant
geometry directly:
- offsetHeight on the flex item proves the spec assertion: the visible
case keeps the 84px intrinsic border-box height; the non-visible
cases shrink to the 30px container.
- offsetWidth on the flex item proves the scroll container correctly
grew its border-box to accommodate the vertical scrollbar gutter,
which is exactly the behavior whose absence would have produced a
spurious horizontal scrollbar in the original reftests.
- scrollWidth === clientWidth on the scrolling cases confirms no
horizontal overflow snuck in.
One could argue that we do not need to have the second point for the
purposes of this test, but I decided to keep them in to limit the number
of changes in the test.
Canonical link: https://commits.webkit.org/313290@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
