Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: baeadcd1b8cb6fdc06e7a2e5fae5ad0cd04d290f
https://github.com/WebKit/WebKit/commit/baeadcd1b8cb6fdc06e7a2e5fae5ad0cd04d290f
Author: Roberto Rodriguez <[email protected]>
Date: 2026-05-14 (Thu, 14 May 2026)
Changed paths:
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/TextureMtl.mm
M Source/ThirdParty/ANGLE/src/tests/gl_tests/MipmapTest.cpp
Log Message:
-----------
ANGLE: Fix crash from stale texture views during size transitions
https://bugs.webkit.org/show_bug.cgi?id=304282
rdar://165836916
Reviewed by Kimmo Kinnunen.
When texture base level size changes (e.g., 128x128 → 256x256), native storage
is recreated but old mipmap views with wrong dimensions can remain in
mTexImageDefs. Uploading to these stale views causes Metal validation failure:
"(origin.x + size.width)(128) must be <= width(64)."
Clear mTexImageDefs entries in generateMipmap() and redefineImage() to ensure
views are always recreated with correct dimensions from current storage.
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/TextureMtl.mm:
(rx::TextureMtl::ensureNativeStorageCreated):
(rx::TextureMtl::generateMipmap):
(rx::TextureMtl::redefineImage):
* Source/ThirdParty/ANGLE/src/tests/gl_tests/MipmapTest.cpp:
Originally-landed-as: 305413.191@safari-7624-branch (0391090cef9a).
rdar://173969233
Canonical link: https://commits.webkit.org/313293@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
