Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 537da1b74f0acf8b208e5f8939aa1ef6b9673a16
https://github.com/WebKit/WebKit/commit/537da1b74f0acf8b208e5f8939aa1ef6b9673a16
Author: Cole Carley <[email protected]>
Date: 2026-05-15 (Fri, 15 May 2026)
Changed paths:
A
LayoutTests/fast/forms/ios/select-menulist-text-align-chevron-padding-expected.txt
A LayoutTests/fast/forms/ios/select-menulist-text-align-chevron-padding.html
A
LayoutTests/platform/ios-simulator/fast/forms/ios/select-menulist-text-align-chevron-padding-expected.png
A
LayoutTests/platform/ios-simulator/fast/text/international/bidi-menulist-expected.png
M LayoutTests/platform/ios/fast/forms/listbox-bidi-align-expected.txt
M
LayoutTests/platform/ios/fast/text/international/bidi-menulist-expected.txt
M Source/WebCore/rendering/ios/RenderThemeIOS.mm
Log Message:
-----------
REGRESSION(309054@main): Select menu list text align padding is wrong
https://bugs.webkit.org/show_bug.cgi?id=314764
rdar://176357057
Reviewed by Alan Baradlay.
309054@main computed padding for select menulist buttons was based on
text-alignment, placing it on the start side when text pointed toward
the chevron (e.g. text-align:right in LTR). This resulted in the text
overlapping with the chevron.
The chevron is always drawn on the logical end regardless of text-align,
so the internal padding should always be placed on the logical end as well.
Test: fast/forms/select-menulist-text-align-chevron-padding.html
*
LayoutTests/fast/forms/select-menulist-text-align-chevron-padding-expected.txt:
Added.
* LayoutTests/fast/forms/select-menulist-text-align-chevron-padding.html: Added.
* LayoutTests/platform/ios/fast/forms/listbox-bidi-align-expected.txt:
* Source/WebCore/rendering/ios/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::platformPopupInternalPaddingBox const):
Canonical link: https://commits.webkit.org/313317@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
