Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c57f26e01334966d2cb89858e1cf54ed729b1f38
https://github.com/WebKit/WebKit/commit/c57f26e01334966d2cb89858e1cf54ed729b1f38
Author: Nikolas Zimmermann <[email protected]>
Date: 2026-05-15 (Fri, 15 May 2026)
Changed paths:
M Tools/Scripts/webkitpy/port/linux_container_sdk_utils.py
Log Message:
-----------
[GTK][WPE][Tools] container-sdk-autoenter fails on bots with /dev/console
mount error
https://bugs.webkit.org/show_bug.cgi?id=314907
Reviewed by Carlos Alberto Lopez Perez.
In nested rootless setups (LXC, k8s pods, Docker/podman) crun aborts
container startup with `mount /dev/pts/N to /dev/console: No such file
or directory`. Root cause: binding the host's entire /dev over the
container's (`-v /dev:/dev:rslave`) shadows the container's /dev, so
under --tty crun cannot create /dev/console from the allocated pty -- a
nested pod's /dev has none for it to bind onto.
Generalize the prior LXC-only check to a `_running_inside_container()`
helper and use it to skip only the wholesale host /dev bind in that
case, letting crun own /dev. --tty and the container's own devpts are
kept, so interactive shells still get a controlling terminal on bots.
GPU (/dev/dri) and e.g. gamepads (/dev/input) are passed through explicitly.
* Tools/Scripts/webkitpy/port/linux_container_sdk_utils.py:
(_running_inside_container):
(_build_podman_run_args):
(maybe_enter_webkit_container_sdk):
Canonical link: https://commits.webkit.org/313330@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
