Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6ada7c61fd44a8919473d8e7a12875b8f4790298
https://github.com/WebKit/WebKit/commit/6ada7c61fd44a8919473d8e7a12875b8f4790298
Author: Alex Christensen <[email protected]>
Date: 2026-05-15 (Fri, 15 May 2026)
Changed paths:
M LayoutTests/applicationmanifest/developer-warnings.html
M LayoutTests/applicationmanifest/multiple-links-expected.txt
M LayoutTests/applicationmanifest/multiple-links.html
M
LayoutTests/http/tests/security/contentSecurityPolicy/manifest-src-allowed-expected.txt
M
LayoutTests/http/tests/security/contentSecurityPolicy/manifest-src-allowed.html
M
LayoutTests/http/tests/security/contentSecurityPolicy/manifest-src-blocked-expected.txt
M
LayoutTests/http/tests/security/contentSecurityPolicy/manifest-src-blocked.html
M
LayoutTests/http/wpt/content-security-policy/sandbox-manifest-blocked-cross-origin.sub-expected.txt
M
LayoutTests/http/wpt/content-security-policy/sandbox-manifest-blocked-cross-origin.sub.html
M
LayoutTests/http/wpt/content-security-policy/sandbox-manifest-blocked-expected.txt
M LayoutTests/http/wpt/content-security-policy/sandbox-manifest-blocked.html
M Source/WebKit/UIProcess/API/C/WKPage.cpp
M Source/WebKit/UIProcess/API/C/WKPagePrivate.h
M Tools/WebKitTestRunner/TestController.cpp
Log Message:
-----------
testRunner.getApplicationManifestThen should return whether fetch was
successful
https://bugs.webkit.org/show_bug.cgi?id=314744
rdar://176994174
Reviewed by Chris Dumez.
This is breaking off a piece of https://github.com/WebKit/WebKit/pull/64581
into its own smaller PR.
Some of the tests for application manifest fetching used
testRunner.dumpResourceLoadCallbacks as a way
of indicating whether the fetch was successful or hit an error. This works
with injected bundle load
callbacks, but doesn't work in a non-flaky way with UI process callbacks
because it hits cases where
NetworkResourceLoader::didRetrieveCacheEntry fails a load sometimes, resulting
in non-deterministic
calls to the _WKResourceLoadDelegate. Rather than doing some invasive changes
in behavior that could
affect actual loading, for this test-only behavior I just expose whether the
fetch was successful and
log that in the test ouptut. The tests continue to test the success or failure
of the load, but now
the test output is deterministic even when the load delegate callbacks will be
moved to the UI process.
* LayoutTests/applicationmanifest/developer-warnings.html:
* LayoutTests/applicationmanifest/multiple-links-expected.txt:
* LayoutTests/applicationmanifest/multiple-links.html:
*
LayoutTests/http/tests/security/contentSecurityPolicy/manifest-src-allowed-expected.txt:
*
LayoutTests/http/tests/security/contentSecurityPolicy/manifest-src-allowed.html:
*
LayoutTests/http/tests/security/contentSecurityPolicy/manifest-src-blocked-expected.txt:
*
LayoutTests/http/tests/security/contentSecurityPolicy/manifest-src-blocked.html:
*
LayoutTests/http/wpt/content-security-policy/sandbox-manifest-blocked-cross-origin.sub-expected.txt:
*
LayoutTests/http/wpt/content-security-policy/sandbox-manifest-blocked-cross-origin.sub.html:
*
LayoutTests/http/wpt/content-security-policy/sandbox-manifest-blocked-expected.txt:
* LayoutTests/http/wpt/content-security-policy/sandbox-manifest-blocked.html:
* Source/WebKit/UIProcess/API/C/WKPage.cpp:
(WKPageGetApplicationManifest):
* Source/WebKit/UIProcess/API/C/WKPagePrivate.h:
* Tools/WebKitTestRunner/TestController.cpp:
Canonical link: https://commits.webkit.org/313332@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
