Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8cc222c1c235ca073af5707fc14a9221b76cd3f0
https://github.com/WebKit/WebKit/commit/8cc222c1c235ca073af5707fc14a9221b76cd3f0
Author: Anthony Tarbinian <[email protected]>
Date: 2026-05-15 (Fri, 15 May 2026)
Changed paths:
M LayoutTests/http/tests/security/cross-origin-local-storage.html
M LayoutTests/platform/ios-site-isolation/TestExpectations
M LayoutTests/platform/mac-site-isolation/TestExpectations
Log Message:
-----------
[Site Isolation] http/tests/security/cross-origin-local-storage.html is
failing
https://bugs.webkit.org/show_bug.cgi?id=314859
rdar://177116495
Reviewed by Sihui Liu.
When site isolation is enabled
http/tests/security/cross-origin-local-storage.html
fails with the following diff compared to with site isolation disabled:
```
-No value
+Got value: value
```
This bug is due to the fact that the test calls
internals.settings.setStorageBlockingPolicy('BlockThirdParty');
which doesn't propagate across process boundaries. This setting controls if
third party
storage accesses go through a blocked/partitioned storage or the real
persistent storage.
This setting is defined in Source/WebCore/page/Settings.yaml and has its C++
setter generated by
Source/WebCore/Scripts/GenerateSettings.rb. This setting is per-page and
doesn't propagate to other processes.
So, in this test the setting was set in the main frame's web process which
didn't
propogate to the cross-origin iframe's web process with site isolation enabled.
This patch modifies this test to set this setting via the following WKTR header:
```
<!-- webkit-test-runner [ StorageBlockingPolicy=1 ] -->
```
which is equivalent to
internals.settings.setStorageBlockingPolicy('BlockThirdParty');
except that it directly modifies WebPreferences
which gets inherited by new processes that spawn up.
This patch fixes http/tests/security/cross-origin-local-storage.html
with site isolation enabled.
* LayoutTests/http/tests/security/cross-origin-local-storage.html:
* LayoutTests/platform/ios-site-isolation/TestExpectations:
* LayoutTests/platform/mac-site-isolation/TestExpectations:
Canonical link: https://commits.webkit.org/313338@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
