Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 72a0e86639cddf61a5e170aa2cb03eb02db8ca1b
https://github.com/WebKit/WebKit/commit/72a0e86639cddf61a5e170aa2cb03eb02db8ca1b
Author: Sam Weinig <[email protected]>
Date: 2026-05-15 (Fri, 15 May 2026)
Changed paths:
M Source/WebCore/SaferCPPExpectations/NoDeleteCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/accessibility/atspi/AccessibilityObjectComponentAtspi.cpp
M Source/WebCore/animation/ViewTimeline.cpp
M Source/WebCore/animation/WebAnimation.cpp
M Source/WebCore/css/CSSCounterStyleDescriptors.cpp
M Source/WebCore/css/CSSFontFace.cpp
M Source/WebCore/css/CSSFontFeatureValue.cpp
M Source/WebCore/css/CSSFontFeatureValue.h
M Source/WebCore/css/CSSPrimitiveValue.cpp
M Source/WebCore/css/CSSPrimitiveValue.h
M Source/WebCore/css/CSSPropertyInitialValues.cpp
M Source/WebCore/css/CSSToLengthConversionData.cpp
M Source/WebCore/css/CSSToLengthConversionData.h
M Source/WebCore/css/CSSUnits.cpp
M Source/WebCore/css/CSSUnits.h
M Source/WebCore/css/CSSValue.h
M Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.cpp
M Source/WebCore/css/ShorthandSerializer.cpp
M Source/WebCore/css/calc/CSSCalcTree+NumericIdentity.h
M Source/WebCore/css/calc/CSSCalcTree+Serialization.cpp
M Source/WebCore/css/calc/CSSCalcTree+Simplification.cpp
M Source/WebCore/css/calc/CSSCalcTree.cpp
M Source/WebCore/css/calc/CSSCalcType.cpp
M Source/WebCore/css/parser/CSSParser.cpp
M Source/WebCore/css/parser/CSSParserToken.cpp
M Source/WebCore/css/parser/CSSParserToken.h
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Animations.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+CounterStyles.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Font.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Timeline.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Transform.cpp
M Source/WebCore/css/scripts/process-css-properties.py
M Source/WebCore/css/typedom/CSSStyleValueFactory.cpp
M Source/WebCore/css/typedom/CSSUnitValue.cpp
M Source/WebCore/css/values/primitives/CSSPrimitiveNumericRange.h
M Source/WebCore/css/values/primitives/CSSUnevaluatedCalc.cpp
M Source/WebCore/css/values/primitives/CSSUnevaluatedCalc.h
M Source/WebCore/dom/ConstantPropertyMap.cpp
M Source/WebCore/editing/ApplyStyleCommand.cpp
M Source/WebCore/editing/EditingStyle.cpp
M Source/WebCore/editing/cocoa/NodeHTMLConverter.mm
M Source/WebCore/rendering/RenderElementStyleInlines.h
M Source/WebCore/rendering/RenderLayer.cpp
M Source/WebCore/rendering/RenderLayerBacking.cpp
M Source/WebCore/rendering/RenderScrollbar.cpp
M Source/WebCore/rendering/RenderScrollbarPart.cpp
M Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp
M Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp
M Source/WebCore/rendering/svg/SVGPaintServerHandlingInlines.h
M Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp
M Source/WebCore/rendering/svg/SVGRenderingContext.cpp
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceGradient.cpp
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourcePattern.cpp
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceSolidColor.cpp
M Source/WebCore/style/StyleBuilderCustom.h
M Source/WebCore/style/StyleResolveForFont.cpp
M Source/WebCore/style/StyleSubstitutionResolver.cpp
M Source/WebCore/style/calc/StyleCalculationValue.cpp
M Source/WebCore/style/calc/StyleCalculationValue.h
M Source/WebCore/style/values/StyleValueTypes.h
M Source/WebCore/style/values/animations/StyleSingleAnimationRange.cpp
M Source/WebCore/style/values/animations/StyleSingleAnimationRange.h
M Source/WebCore/style/values/color/StyleOpacity.cpp
M Source/WebCore/style/values/color/StyleOpacity.h
M Source/WebCore/style/values/fonts/StyleFontFeatureSettings.cpp
M Source/WebCore/style/values/primitives/StyleLengthResolution.cpp
M
Source/WebCore/style/values/primitives/StyleLengthWrapper+CSSValueConversion.h
R
Source/WebCore/style/values/primitives/StyleLengthWrapper+DeprecatedCSSValueConversion.cpp
M
Source/WebCore/style/values/primitives/StyleLengthWrapper+DeprecatedCSSValueConversion.h
M
Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+CSSValueConversion.h
A
Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+DeprecatedCSSValueConversion.h
A
Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+DeprecatedConversions.h
M Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes.h
M Source/WebCore/style/values/primitives/StyleUnevaluatedCalculation.cpp
M Source/WebCore/style/values/primitives/StyleUnevaluatedCalculation.h
M Source/WebCore/svg/SVGFEDropShadowElement.cpp
M Source/WebCore/svg/SVGFEFloodElement.cpp
M Source/WebCore/svg/SVGStopElement.cpp
Log Message:
-----------
[Style] Unify numeric type resolution functions (part 2)
https://bugs.webkit.org/show_bug.cgi?id=314570
Reviewed by Darin Adler.
The goal of this refactoring series is to unify the way `CSSPrimitiveValue`
values get resolved.
This second change focuses on removing the remaining
`resolveAs{type}{modifier}()`
functions from CSSPrimitiveValue and transitioning to using the `Style::toStyle`
families of functions. To achieve this, new "deprecated" versions of
`Style::toStyle`
and `Style::toStyleFromCSSValue` were added for all numeric types to support
migrating the `resolveAs{type}Deprecated()` variants.
With all resolution removed from `CSSPrimitiveValue`, `getFloatValueDeprecated`
no longer makes sense on `CSSPrimitiveValue` and is moved to live entirely on
`DeprecatedCSSOMPrimitiveValue`. This allows us to remove
`CSSUnitType::CSS_DIMENSION`
which was only used by DeprecatedCSSOMPrimitiveValue to communicate to
`getFloatValueDeprecated`.
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/accessibility/atspi/AccessibilityObjectComponentAtspi.cpp:
* Source/WebCore/animation/ViewTimeline.cpp:
* Source/WebCore/animation/WebAnimation.cpp:
* Source/WebCore/css/CSSCounterStyleDescriptors.cpp:
* Source/WebCore/css/CSSFontFace.cpp:
* Source/WebCore/css/CSSFontFeatureValue.cpp:
* Source/WebCore/css/CSSFontFeatureValue.h:
* Source/WebCore/css/CSSPrimitiveValue.cpp:
* Source/WebCore/css/CSSPrimitiveValue.h:
* Source/WebCore/css/CSSPropertyInitialValues.cpp:
* Source/WebCore/css/CSSToLengthConversionData.cpp:
* Source/WebCore/css/CSSToLengthConversionData.h:
* Source/WebCore/css/CSSUnits.cpp:
* Source/WebCore/css/CSSUnits.h:
* Source/WebCore/css/CSSValue.h:
* Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.cpp:
* Source/WebCore/css/ShorthandSerializer.cpp:
* Source/WebCore/css/calc/CSSCalcTree+NumericIdentity.h:
* Source/WebCore/css/calc/CSSCalcTree+Serialization.cpp:
* Source/WebCore/css/calc/CSSCalcTree+Simplification.cpp:
* Source/WebCore/css/calc/CSSCalcTree.cpp:
* Source/WebCore/css/calc/CSSCalcType.cpp:
* Source/WebCore/css/parser/CSSParser.cpp:
* Source/WebCore/css/parser/CSSParserToken.cpp:
* Source/WebCore/css/parser/CSSParserToken.h:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Animations.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+CounterStyles.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Font.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Timeline.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Transform.cpp:
* Source/WebCore/css/scripts/process-css-properties.py:
* Source/WebCore/css/typedom/CSSStyleValueFactory.cpp:
* Source/WebCore/css/typedom/CSSUnitValue.cpp:
* Source/WebCore/css/values/primitives/CSSPrimitiveNumericRange.h:
* Source/WebCore/css/values/primitives/CSSUnevaluatedCalc.cpp:
* Source/WebCore/css/values/primitives/CSSUnevaluatedCalc.h:
* Source/WebCore/dom/ConstantPropertyMap.cpp:
* Source/WebCore/editing/ApplyStyleCommand.cpp:
* Source/WebCore/editing/EditingStyle.cpp:
* Source/WebCore/editing/cocoa/NodeHTMLConverter.mm:
* Source/WebCore/rendering/RenderElementStyleInlines.h:
* Source/WebCore/rendering/RenderLayer.cpp:
* Source/WebCore/rendering/RenderLayerBacking.cpp:
* Source/WebCore/rendering/RenderScrollbar.cpp:
* Source/WebCore/rendering/RenderScrollbarPart.cpp:
* Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp:
* Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp:
* Source/WebCore/rendering/svg/SVGPaintServerHandlingInlines.h:
* Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp:
* Source/WebCore/rendering/svg/SVGRenderingContext.cpp:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceGradient.cpp:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourcePattern.cpp:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceSolidColor.cpp:
* Source/WebCore/style/StyleBuilderCustom.h:
* Source/WebCore/style/StyleResolveForFont.cpp:
* Source/WebCore/style/StyleSubstitutionResolver.cpp:
* Source/WebCore/style/calc/StyleCalculationValue.cpp:
* Source/WebCore/style/calc/StyleCalculationValue.h:
* Source/WebCore/style/values/StyleValueTypes.h:
* Source/WebCore/style/values/animations/StyleSingleAnimationRange.cpp:
* Source/WebCore/style/values/animations/StyleSingleAnimationRange.h:
* Source/WebCore/style/values/color/StyleOpacity.cpp:
* Source/WebCore/style/values/color/StyleOpacity.h:
* Source/WebCore/style/values/fonts/StyleFontFeatureSettings.cpp:
* Source/WebCore/style/values/primitives/StyleLengthResolution.cpp:
*
Source/WebCore/style/values/primitives/StyleLengthWrapper+CSSValueConversion.h:
*
Source/WebCore/style/values/primitives/StyleLengthWrapper+DeprecatedCSSValueConversion.cpp:
Removed.
*
Source/WebCore/style/values/primitives/StyleLengthWrapper+DeprecatedCSSValueConversion.h:
*
Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+CSSValueConversion.h:
*
Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+DeprecatedCSSValueConversion.h:
Added.
*
Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+DeprecatedConversions.h:
Added.
* Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes.h:
* Source/WebCore/style/values/primitives/StyleUnevaluatedCalculation.cpp:
* Source/WebCore/style/values/primitives/StyleUnevaluatedCalculation.h:
* Source/WebCore/svg/SVGFEDropShadowElement.cpp:
* Source/WebCore/svg/SVGFEFloodElement.cpp:
* Source/WebCore/svg/SVGStopElement.cpp:
Canonical link: https://commits.webkit.org/313346@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
