Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 99c338623e067e47576430f7ba54db0fd5cd454c
https://github.com/WebKit/WebKit/commit/99c338623e067e47576430f7ba54db0fd5cd454c
Author: Chris Dumez <[email protected]>
Date: 2026-05-16 (Sat, 16 May 2026)
Changed paths:
M Source/WebKit/UIProcess/Cocoa/ProcessAssertionCocoa.mm
M Source/WebKit/UIProcess/ProcessAssertion.h
M Tools/Scripts/webkitpy/style/checkers/cpp.py
Log Message:
-----------
Unreviewed, reverting 312175@main (c53a7f951fa0)
https://bugs.webkit.org/show_bug.cgi?id=314945
rdar://176995929
Unreviewed, revert 312175@main since it introduced crashes. The issue is
two-fold:
- The process assertion no longer gets invalidated at a well defined time
(i.e. when we don't need it anymore). Since it is an Objective C object,
the destructor runs when the pool gets drained, which may be quite a bit
later.
- This also means that invalidation can now
happen on any thread, including
some runningboard threads, instead of the main thread like it used to.
This is not safe and leads to crashes.
Reverted change:
Create WKRBSAssertion subclass of RBSAssertion to prevent missing
invalidate calls
https://bugs.webkit.org/show_bug.cgi?id=313382
rdar://175648970
312175@main (c53a7f951fa0)
Canonical link:
https://flagged.apple.com:443/proxy?t2=Df9i1e2FM6&o=aHR0cHM6Ly9jb21taXRzLndlYmtpdC5vcmcvMzEzMzU3QG1haW4=&emid=94619e41-4926-4fc2-be10-8d0be2867a6a&c=11
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications