Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5780e754ea9b4c86d6c9c61f486ae67f960dc2ae
https://github.com/WebKit/WebKit/commit/5780e754ea9b4c86d6c9c61f486ae67f960dc2ae
Author: Geoffrey Garen <[email protected]>
Date: 2026-05-17 (Sun, 17 May 2026)
Changed paths:
M Source/JavaScriptCore/CMakeLists.txt
M Source/WTF/wtf/CMakeLists.txt
M Source/WebCore/CMakeLists.txt
M Source/WebCore/PAL/pal/CMakeLists.txt
M Source/WebKit/CMakeLists.txt
M Source/cmake/OptionsGTK.cmake
M Source/cmake/OptionsWPE.cmake
M Source/cmake/WebKitCompilerFlags.cmake
Log Message:
-----------
[CMake] Standardize -Wunsafe-buffer-usage flags
https://bugs.webkit.org/show_bug.cgi?id=314991
rdar://177299438
Reviewed by Adrian Perez de Castro.
-Wunsafe-buffer-usage is in a subtly mixed state across Mac / GTK / WPE.
1. Create a central location for -Wunsafe-buffer-usage, so that it is either ON
or OFF.
2. The standard definition of -Wunsafe-buffer-usage includes libc warnings
(since the alternative misses important well-known buffer overflows).
3. GTK and WPE opt out of libc warnings in their port-specific configs (as
previously decided by GTK and WPE maintainers).
4. Darwin ports keep -Wunsafe-buffer-usage off for now, pending a fix for
https://github.com/llvm/llvm-project/pull/198006, since we are using CMake
for our fast at-desk build and we don't want to regress build time.
* Source/JavaScriptCore/CMakeLists.txt:
* Source/WTF/wtf/CMakeLists.txt:
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/PAL/pal/CMakeLists.txt:
* Source/WebKit/CMakeLists.txt:
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/WebKitCompilerFlags.cmake:
Canonical link: https://commits.webkit.org/313391@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
