Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5a55efcfb4ea7be0aac38200beeb3d4a77f4754c
https://github.com/WebKit/WebKit/commit/5a55efcfb4ea7be0aac38200beeb3d4a77f4754c
Author: Sam Sneddon <[email protected]>
Date: 2026-05-18 (Mon, 18 May 2026)
Changed paths:
M Tools/Scripts/webkitpy/w3c/test_converter.py
M Tools/Scripts/webkitpy/w3c/test_converter_unittest.py
M Tools/Scripts/webkitpy/w3c/test_importer.py
M Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
Log Message:
-----------
[import-w3c-tests] Avoid needlessly rewriting tests on import
https://bugs.webkit.org/show_bug.cgi?id=314663
rdar://176914827
Reviewed by Ryosuke Niwa and Anne van Kesteren.
* Tools/Scripts/webkitpy/w3c/test_converter.py:
(convert_for_webkit): Return None when there's nothing to modified; assert we
only get expected file extensions.
(_W3CTestConverter.__init__): Add _W3CTestConverter._modified.
(_W3CTestConverter.output): Return None if nothing is modified.
(_W3CTestConverter.convert_reference_relpaths): Set modified.
(_W3CTestConverter.convert_style_data): Set modified.
(_W3CTestConverter.convert_attributes_if_needed): Set modified.
(_W3CTestConverter.add_webkit_test_runner_options_if_needed): Set modified.
* Tools/Scripts/webkitpy/w3c/test_converter_unittest.py: Update tests for None.
* Tools/Scripts/webkitpy/w3c/test_importer.py:
(TestImporter.import_tests): Don't pass JS to the rewriter.
* Tools/Scripts/webkitpy/w3c/test_importer_unittest.py:
(TestImporterTest.test_unmodified_files_not_rewritten): Add a test that we
don't rewrite everything.
Canonical link: https://commits.webkit.org/313428@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
