Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 59a20ddcb9ca0eecd9bd88bce32ffc8900c4fbcb
https://github.com/WebKit/WebKit/commit/59a20ddcb9ca0eecd9bd88bce32ffc8900c4fbcb
Author: Yusuke Suzuki <[email protected]>
Date: 2026-05-19 (Tue, 19 May 2026)
Changed paths:
A JSTests/stress/object-define-property-fields-spilled-arg.js
M Source/JavaScriptCore/dfg/DFGOperations.cpp
M Source/JavaScriptCore/dfg/DFGOperations.h
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp
M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp
Log Message:
-----------
[JSC] Use scratch buffer for ObjectDefinePropertyFromFields
https://bugs.webkit.org/show_bug.cgi?id=315074
rdar://177332941
Reviewed by Keith Miller.
ObjectDefinePropertyFromFields is calling an operation with 9
parameters. But ARM64 / x64 right now only supports up to 6 register
parameters. And our DFG JIT is currently assuming that ARM64 / x64 never
uses stack for parameter passing. This patch fixes this issue by using
scratch buffer for fields.
Test: JSTests/stress/object-define-property-fields-spilled-arg.js
* JSTests/stress/object-define-property-fields-spilled-arg.js: Added.
(opt.try.Inner.prototype.method):
(opt.try.Inner):
(opt.get a2):
(opt):
(i.catch):
* Source/JavaScriptCore/dfg/DFGOperations.cpp:
(JSC::DFG::JSC_DEFINE_JIT_OPERATION):
* Source/JavaScriptCore/dfg/DFGOperations.h:
* Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:
* Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileObjectDefinePropertyFromFields):
Canonical link: https://commits.webkit.org/313474@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
