Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f0e5651a9d939a3861e0d0c8e089797d69c9e411
https://github.com/WebKit/WebKit/commit/f0e5651a9d939a3861e0d0c8e089797d69c9e411
Author: Claudio Saavedra <[email protected]>
Date: 2026-05-19 (Tue, 19 May 2026)
Changed paths:
M Tools/CISupport/ews-build/factories.py
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
Log Message:
-----------
[EWS] Add support to skip testing specific branches
https://bugs.webkit.org/show_bug.cgi?id=315083
Reviewed by Aakash Jain.
In the Linux ports, we have started using EWS to test that cherry-picked changes
to stable branches don't introduce regressions. This currently has the downside
of triggering every single EWS queue to process these patches, even when it is
likely that they don't even build in Mac or iOS after the divergence between
the branches and the Apple ports.
This change addresses this by adding a excluded_branches property to the
ValidateChange step, akin to the branches property. When specified, the
step will first check if the branch being tested should be skipped, in
which case it will just log 'Changes to branch x are not tested'.
The base Factory class defaults excluded_branches to skip the webkitglib stable
branches. Factory.__init__ then passes an empty list to ValidateChange when
running on a Linux platform, and the class default otherwise. This way,
only Linux-specific factories will process these branches. Additionally,
disallow glib stable branches from safer CPP queues, and allow them in
bindings, perl, and python queues.
Add also unit tests for this.
* Tools/CISupport/ews-build/factories.py:
(Factory):
(Factory.__init__):
(SaferCPPStaticAnalyzerFactory):
(SaferCPPStaticAnalyzerFactory.__init__):
(BindingsFactory):
(WebKitPerlFactory):
(WebKitPyFactory):
* Tools/CISupport/ews-build/steps.py:
(ValidateChange.__init__):
(ValidateChange):
(ValidateChange.run):
* Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/313514@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
