[webkit-changes] [WebKit/WebKit] c47834: Model attempts to download invalid USD files

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c478340a431f31696ed16610f0f1d9eee85037ad
      
https://github.com/WebKit/WebKit/commit/c478340a431f31696ed16610f0f1d9eee85037ad
  Author: Mike Wyrzykowski <mwyrzykow...@apple.com>
  Date:   2026-05-19 (Tue, 19 May 2026)

  Changed paths:
    A LayoutTests/model-element/model-element-404-error-expected.txt
    A LayoutTests/model-element/model-element-404-error.html
    M Source/WebCore/Modules/model-element/HTMLModelElement.cpp
    M Source/WebKit/GPUProcess/graphics/Model/ModelTypes.h
    M Source/WebKit/GPUProcess/graphics/Model/USDModel.swift
    M Source/WebKit/WebProcess/Model/WebModelPlayer.mm

  Log Message:
  -----------
  Model attempts to download invalid USD files
rdar://177178825
https://bugs.webkit.org/show_bug.cgi?id=314911

Reviewed by Etienne Segonzac.

If we get a 404 or similar invalid response code, we shouldn't attempt
to proceeed to parse the USD.

Also report failure in parsing files which exist and call the delegate's
didFailLoading function.

Test: model-element/model-element-404-error.html

* LayoutTests/model-element/model-element-404-error-expected.txt: Added.
* LayoutTests/model-element/model-element-404-error.html: Added.
* Source/WebCore/Modules/model-element/HTMLModelElement.cpp:
(WebCore::HTMLModelElement::modelResourceFinished):
* Source/WebKit/GPUProcess/graphics/Model/ModelTypes.h:
* Source/WebKit/GPUProcess/graphics/Model/USDModel.swift:
(USDModelLoader.loadModel(_:)):
(USDModelLoader.loadModel(from:)):
(WKBridgeModelLoader.loadModel(_:)):
* Source/WebKit/WebProcess/Model/WebModelPlayer.mm:
(WebKit::WebModelPlayer::load):

Canonical link: https://commits.webkit.org/313542@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications