Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3da609a1e0ad1560aa6064807e3dbd84a08f79d9
https://github.com/WebKit/WebKit/commit/3da609a1e0ad1560aa6064807e3dbd84a08f79d9
Author: Phinehas Fuachie <[email protected]>
Date: 2026-05-20 (Wed, 20 May 2026)
Changed paths:
A
LayoutTests/media/modern-media-controls/tracks-support/audio-text-tracks-not-shown-expected.txt
A
LayoutTests/media/modern-media-controls/tracks-support/audio-text-tracks-not-shown.html
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/mac-wk2/TestExpectations
M Source/WebCore/Modules/modern-media-controls/media/overflow-support.js
M Source/WebCore/Modules/modern-media-controls/media/tracks-support.js
Log Message:
-----------
Built-in media controls show subtitles option for <audio> elements even
though there is nowhere to display them
https://bugs.webkit.org/show_bug.cgi?id=315029
rdar://175357130
Reviewed by Jer Noble.
Audio elements have no visual rendering area for subtitle/caption text, so the
subtitles option in
the media controls context menu is non-functional. Exclude text tracks from
enabling the tracks
button for audio elements, and pass includeSubtitles: false when showing the
context menu for both
the tracks button and overflow button paths.
*
LayoutTests/media/modern-media-controls/tracks-support/audio-text-tracks-not-shown-expected.txt:
Added.
*
LayoutTests/media/modern-media-controls/tracks-support/audio-text-tracks-not-shown.html:
Added.
* Source/WebCore/Modules/modern-media-controls/media/overflow-support.js:
(OverflowSupport.prototype.buttonWasPressed):
* Source/WebCore/Modules/modern-media-controls/media/tracks-support.js:
(TracksSupport.prototype.buttonWasPressed):
(TracksSupport.prototype._canPickTextTracks):
Canonical link: https://commits.webkit.org/313577@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
