Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5f0bcdea961815239de9c33388b6f020abda94a8
https://github.com/WebKit/WebKit/commit/5f0bcdea961815239de9c33388b6f020abda94a8
Author: Nikolas Zimmermann <[email protected]>
Date: 2026-05-22 (Fri, 22 May 2026)
Changed paths:
M Tools/TestWebKitAPI/PlatformGTK.cmake
M Tools/TestWebKitAPI/PlatformWPE.cmake
M Tools/WebKitTestRunner/PlatformGTK.cmake
M Tools/WebKitTestRunner/PlatformWPE.cmake
Log Message:
-----------
[GTK][WPE] Fix -j1 builds by wiring test targets to forwarding-headers
https://bugs.webkit.org/show_bug.cgi?id=315383
Reviewed by Carlos Alberto Lopez Perez.
Tools/TestWebKitAPI/config.h pulls in <WebKit/WebKit2_C.h> for the
BUILDING_TestWebKit translation units, and Tools/WebKitTestRunner/config.h
does the same for TestRunnerInjectedBundle. Those forwarding headers are
generated by the per-tool *-forwarding-headers targets (the Source/WebKit
variant scans only Source/WebKit/, where no <WebKit/...> include for these
headers exists).
WebKitGLibAPITestsCore and TestRunnerInjectedBundle had no build-order
dependency to those targets. With -jN the build happened to succeed; with
-j1 ninja compiled them before the forwarding header was created and
failed with "WebKit/WebKit2_C.h file not found".
* Tools/TestWebKitAPI/PlatformGTK.cmake:
* Tools/TestWebKitAPI/PlatformWPE.cmake:
* Tools/WebKitTestRunner/PlatformGTK.cmake:
* Tools/WebKitTestRunner/PlatformWPE.cmake:
Canonical link: https://commits.webkit.org/313760@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
