[webkit-changes] [WebKit/WebKit] 6b0e6b: Implement popover integration with close watcher

[Luke Warlow]

Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6b0e6bababc515e5035653c11780824ce168c377
      
https://github.com/WebKit/WebKit/commit/6b0e6bababc515e5035653c11780824ce168c377
  Author: Luke Warlow <lwar...@igalia.com>
  Date:   2026-05-25 (Mon, 25 May 2026)

  Changed paths:
    M LayoutTests/TestExpectations
    M 
LayoutTests/imported/w3c/web-platform-tests/close-watcher/user-activation/nnn-popovers-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/close-watcher/user-activation/nyn-popovers-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-synthetic-keydown-expected.txt
    M Source/WebCore/dom/PopoverData.h
    M Source/WebCore/html/HTMLElement.cpp
    M Source/WebCore/html/closewatcher/CloseWatcher.cpp
    M Source/WebCore/html/closewatcher/CloseWatcher.h
    M Source/WebCore/page/EventHandler.cpp

  Log Message:
  -----------
  Implement popover integration with
close
watcher
https://bugs.webkit.org/show_bug.cgi?id=274719

Reviewed by Anne van Kesteren.

Implement the internal close watcher for popovers.

Spec: 
https://flagged.apple.com:443/proxy?t2=DV5I8q4at9&o=aHR0cHM6Ly9odG1sLnNwZWMud2hhdHdnLm9yZy9tdWx0aXBhZ2UvcG9wb3Zlci5odG1sI3BvcG92ZXItY2xvc2Utd2F0Y2hlcg==&emid=3a922383-e44c-4de7-86f1-c220c402d048&c=11

* LayoutTests/TestExpectations:
* 
LayoutTests/imported/w3c/web-platform-tests/close-watcher/user-activation/nnn-popovers-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/close-watcher/user-activation/nyn-popovers-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-synthetic-keydown-expected.txt:
*
Source/WebCore/dom/PopoverData.h:
(WebCore::PopoverData::closeWatcher):
(WebCore::PopoverData::setCloseWatcher):
*
Source/WebCore/html/HTMLElement.cpp:
(WebCore::PopoverData::PopoverCloseWatcherEventListener::PopoverCloseWatcherEventListener):
(WebCore::PopoverData::PopoverCloseWatcherEventListener::handleEvent):
(WebCore::HTMLElement::showPopoverInternal):
(WebCore::HTMLElement::hidePopoverInternal):
* Source/WebCore/html/closewatcher/CloseWatcher.cpp:
(WebCore::CloseWatcher::create):
* Source/WebCore/html/closewatcher/CloseWatcher.h:
* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::defaultKeyboardEventHandler):

Canonical link: 
https://flagged.apple.com:443/proxy?t2=DO1g3q9Re0&o=aHR0cHM6Ly9jb21taXRzLndlYmtpdC5vcmcvMzEzODM4QG1haW4=&emid=3a922383-e44c-4de7-86f1-c220c402d048&c=11



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications