Branch: refs/heads/webkitglib/2.52
Home: https://github.com/WebKit/WebKit
Commit: 29ec063b656355b971fbb6e1703b44ba221091df
https://github.com/WebKit/WebKit/commit/29ec063b656355b971fbb6e1703b44ba221091df
Author: Chris Dumez <[email protected]>
Date: 2026-05-26 (Tue, 26 May 2026)
Changed paths:
M Source/WebKit/NetworkProcess/storage/CacheStorageCache.cpp
M Source/WebKit/NetworkProcess/storage/CacheStorageCache.h
M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp
M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h
Log Message:
-----------
Cherry-pick 305413.546@safari-7624-branch (1df88b983792).
https://bugs.webkit.org/show_bug.cgi?id=310177
CacheStorageCache::computeKeyURL() can cause network process to crash on
bad IPC
https://bugs.webkit.org/show_bug.cgi?id=310177
rdar://172058080
Reviewed by Sihui Liu.
CacheStorageCache::computeKeyURL() can cause network process to crash on
bad IPC from the WebContent process, due to release assertions.
To address the issue, replace the debug assertions in
CacheStorageCache::computeKeyURL() and returning std::nullopt in release
builds. The call sites then rely on MESSAGE_CHECK when computeKeyURL()
returns std::nullopt to terminate the process that sent the bad IPC.
* Source/WebKit/NetworkProcess/storage/CacheStorageCache.cpp:
(WebKit::CacheStorageCache::computeKeyURL):
(WebKit::CacheStorageCache::open):
(WebKit::CacheStorageCache::retrieveRecords):
(WebKit::CacheStorageCache::removeRecords):
(WebKit::CacheStorageCache::findExistingRecord):
(WebKit::CacheStorageCache::putRecords):
(WebKit::CacheStorageCache::putRecordsAfterQuotaCheck):
(WebKit::CacheStorageCache::putRecordsInStore):
* Source/WebKit/NetworkProcess/storage/CacheStorageCache.h:
* Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp:
(WebKit::NetworkStorageManager::cacheStorageRetrieveRecords):
(WebKit::NetworkStorageManager::cacheStorageRemoveRecords):
(WebKit::NetworkStorageManager::cacheStoragePutRecords):
* Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h:
* Tools/TestWebKitAPI/Tests/WebKit/FetchLocalFile.mm:
(TEST(WebKit, FetchLocalFileFromTempDirectory)):
Fix flaky test that kept causing issues on EWS.
Identifier: 305413.546@safari-7624-branch
Canonical link: https://commits.webkit.org/305877.680@webkitglib/2.52
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
