Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 621eba1b86cf1c03d77ba59ea5c606d7f1c0fca8
https://github.com/WebKit/WebKit/commit/621eba1b86cf1c03d77ba59ea5c606d7f1c0fca8
Author: Zak Ridouh <[email protected]>
Date: 2026-05-26 (Tue, 26 May 2026)
Changed paths:
M Source/cmake/OptionsIOS.cmake
M Source/cmake/OptionsMac.cmake
M Source/cmake/WebKitFeatures.cmake
Log Message:
-----------
[CMake] PredefinedColorSpace IDL enum missing "display-p3" values
https://bugs.webkit.org/show_bug.cgi?id=315493
rdar://177860063
Reviewed by Simon Fraser.
In the CMake build, canvas.getContext('2d', { colorSpace: 'display-p3' })
threw because the generated PredefinedColorSpace bindings were missing
the "display-p3" enum value.
Register the option and enable it for Mac and iOS.
Basically, PredefinedColorSpace.idl gates "display-p3" and "display-p3-linear"
behind ENABLE_PREDEFINED_COLOR_SPACE_DISPLAY_P3.
The IDL preprocessor only sees defines from FEATURE_DEFINES, which is built from
WEBKIT_OPTION_DEFINE entries, not from PlatformEnableCocoa.h, where
this flag is actually set on Cocoa. Since the flag was never registered
as a WebKit option, the IDL preprocessor stripped the display-p3 values
out.
* Source/cmake/OptionsIOS.cmake:
* Source/cmake/OptionsMac.cmake:
* Source/cmake/WebKitFeatures.cmake:
Canonical link: https://commits.webkit.org/313908@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
