Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4029f1176cf754142738523efa92957ce3b8ead7
https://github.com/WebKit/WebKit/commit/4029f1176cf754142738523efa92957ce3b8ead7
Author: Sam Weinig <[email protected]>
Date: 2026-05-27 (Wed, 27 May 2026)
Changed paths:
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/css/CSSValue.cpp
M Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMCounter.h
A Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMCustomValue.cpp
A Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMCustomValue.h
M
Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMLazySerializingCustomValue.cpp
M
Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMLazySerializingCustomValue.h
M Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMPrimitiveValue.cpp
M Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMPrimitiveValue.h
A Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMRGBColor.cpp
M Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMRGBColor.h
A Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMRect.cpp
M Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMRect.h
M Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMValue.cpp
M Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMValue.h
M Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMValueList.cpp
M Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMValueList.h
M Source/WebCore/css/values/CSSValueTypes.cpp
M Source/WebCore/style/StyleCustomProperty.cpp
Log Message:
-----------
Simplify DeprecatedCSSOMValue class hierarchy by using virtual functions
https://bugs.webkit.org/show_bug.cgi?id=315582
Reviewed by Darin Adler.
Replaces bespoke/switch-based virtual dispatch with real virtual functions
in DeprecatedCSSOMValue hierarchy. The switch-base dispatch is an artifact
from when DeprecatedCSSOMValue was extracted from CSSValue, and is only needed
in places where performance is critical.
Also renames DeprecatedCSSOMComplexValue to DeprecatedCSSOMCustomValue,
matching its type enum value CSS_CUSTOM and moved it into its own files.
Also moved a few other functions from being inline to the implementation
file to avoid unnecessary includes in the headers.
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSValue.cpp:
* Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMCounter.h:
* Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMCustomValue.cpp: Added.
* Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMCustomValue.h: Added.
*
Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMLazySerializingCustomValue.cpp:
*
Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMLazySerializingCustomValue.h:
* Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMPrimitiveValue.cpp:
* Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMPrimitiveValue.h:
* Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMRGBColor.cpp: Added.
* Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMRGBColor.h:
* Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMRect.cpp: Added.
* Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMRect.h:
* Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMValue.cpp:
* Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMValue.h:
* Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMValueList.cpp:
* Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMValueList.h:
* Source/WebCore/css/values/CSSValueTypes.cpp:
* Source/WebCore/style/StyleCustomProperty.cpp:
Canonical link: https://commits.webkit.org/313973@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
