Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d61d43e680e122500d5db92a8d191775d438591f
https://github.com/WebKit/WebKit/commit/d61d43e680e122500d5db92a8d191775d438591f
Author: Sosuke Suzuki <[email protected]>
Date: 2026-05-28 (Thu, 28 May 2026)
Changed paths:
A JSTests/microbenchmarks/weak-map-constructor-empty.js
A JSTests/microbenchmarks/weak-set-constructor-empty.js
A JSTests/stress/new-weak-map-weak-set-dfg.js
M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h
M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp
M Source/JavaScriptCore/dfg/DFGClobberize.h
M Source/JavaScriptCore/dfg/DFGClobbersExitState.cpp
M Source/JavaScriptCore/dfg/DFGCloneHelper.h
M Source/JavaScriptCore/dfg/DFGDoesGC.cpp
M Source/JavaScriptCore/dfg/DFGFixupPhase.cpp
M Source/JavaScriptCore/dfg/DFGMayExit.cpp
M Source/JavaScriptCore/dfg/DFGNode.h
M Source/JavaScriptCore/dfg/DFGNodeType.h
M Source/JavaScriptCore/dfg/DFGOperations.cpp
M Source/JavaScriptCore/dfg/DFGOperations.h
M Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp
M Source/JavaScriptCore/dfg/DFGSafeToExecute.h
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp
M Source/JavaScriptCore/dfg/DFGStoreBarrierInsertionPhase.cpp
M Source/JavaScriptCore/ftl/FTLCapabilities.cpp
M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp
Log Message:
-----------
[JSC] Add NewWeakMap and NewWeakSet DFG nodes
https://bugs.webkit.org/show_bug.cgi?id=315326
Reviewed by Yusuke Suzuki.
new Map() / new Set() already have dedicated DFG nodes, but new WeakMap() and
new WeakSet() always go through the generic construct path. This patch adds
NewWeakMap / NewWeakSet DFG nodes so that argument-less construction with
new.target == callee directly calls operationNewWeakMap / operationNewWeakSet
in DFG and FTL.
Unlike NewMap / NewSet, we do not inline-allocate the cell yet since
WeakMapImpl eagerly allocates its buffer with malloc in the constructor
(left as a FIXME).
TipOfTree Patched
weak-map-constructor-empty 64.4507+-40.5876 46.8354+-1.7024
might be 1.3761x faster
weak-set-constructor-empty 70.4823+-38.5420 54.8688+-33.7160
might be 1.2846x faster
Tests: JSTests/microbenchmarks/weak-map-constructor-empty.js
JSTests/microbenchmarks/weak-set-constructor-empty.js
JSTests/stress/new-weak-map-weak-set-dfg.js
* JSTests/microbenchmarks/weak-map-constructor-empty.js: Added.
(test):
* JSTests/microbenchmarks/weak-set-constructor-empty.js: Added.
(test):
* JSTests/stress/new-weak-map-weak-set-dfg.js: Added.
(assert):
(createWeakMap):
(createWeakSet):
(set createWeakMapWithEntries):
(createWeakSetWithEntries):
(i.set add):
(MyWeakMap):
(MyWeakSet):
(createSubclassed):
* Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
* Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleConstantFunction):
* Source/JavaScriptCore/dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* Source/JavaScriptCore/dfg/DFGClobbersExitState.cpp:
(JSC::DFG::clobbersExitState):
* Source/JavaScriptCore/dfg/DFGCloneHelper.h:
* Source/JavaScriptCore/dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
* Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* Source/JavaScriptCore/dfg/DFGMayExit.cpp:
* Source/JavaScriptCore/dfg/DFGNode.h:
(JSC::DFG::Node::hasStructure):
* Source/JavaScriptCore/dfg/DFGNodeType.h:
* Source/JavaScriptCore/dfg/DFGOperations.cpp:
(JSC::DFG::JSC_DEFINE_JIT_OPERATION):
* Source/JavaScriptCore/dfg/DFGOperations.h:
* Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp:
* Source/JavaScriptCore/dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
* Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:
* Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:
* Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* Source/JavaScriptCore/dfg/DFGStoreBarrierInsertionPhase.cpp:
* Source/JavaScriptCore/ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
Canonical link: https://commits.webkit.org/314028@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
