Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a758094f8699e775ce7ecce1a5f7941f8c934848
https://github.com/WebKit/WebKit/commit/a758094f8699e775ce7ecce1a5f7941f8c934848
Author: Alan Baradlay <[email protected]>
Date: 2026-05-28 (Thu, 28 May 2026)
Changed paths:
M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp
M Source/WebCore/rendering/RenderBlock.cpp
M Source/WebCore/rendering/RenderBlock.h
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp
M Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h
M Source/WebCore/rendering/RenderFileUploadControl.cpp
M Source/WebCore/rendering/RenderFileUploadControl.h
M Source/WebCore/rendering/RenderFlexibleBox.cpp
M Source/WebCore/rendering/RenderFragmentContainer.cpp
M Source/WebCore/rendering/RenderFragmentContainer.h
M Source/WebCore/rendering/RenderListBox.cpp
M Source/WebCore/rendering/RenderListBox.h
M Source/WebCore/rendering/RenderListItem.cpp
M Source/WebCore/rendering/RenderListItem.h
M Source/WebCore/rendering/RenderListMarker.cpp
M Source/WebCore/rendering/RenderListMarker.h
M Source/WebCore/rendering/RenderMenuList.cpp
M Source/WebCore/rendering/RenderMenuList.h
M Source/WebCore/rendering/RenderReplaced.cpp
M Source/WebCore/rendering/RenderReplaced.h
M Source/WebCore/rendering/RenderReplica.cpp
M Source/WebCore/rendering/RenderReplica.h
M Source/WebCore/rendering/RenderSlider.cpp
M Source/WebCore/rendering/RenderSlider.h
M Source/WebCore/rendering/RenderTable.cpp
M Source/WebCore/rendering/RenderTable.h
M Source/WebCore/rendering/RenderTableCell.cpp
M Source/WebCore/rendering/RenderTableCell.h
M Source/WebCore/rendering/RenderTableCol.h
M Source/WebCore/rendering/RenderTextControl.cpp
M Source/WebCore/rendering/RenderTextControl.h
M Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp
M Source/WebCore/rendering/mathml/RenderMathMLFraction.h
M Source/WebCore/rendering/mathml/RenderMathMLMenclose.cpp
M Source/WebCore/rendering/mathml/RenderMathMLMenclose.h
M Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp
M Source/WebCore/rendering/mathml/RenderMathMLOperator.h
M Source/WebCore/rendering/mathml/RenderMathMLPadded.cpp
M Source/WebCore/rendering/mathml/RenderMathMLPadded.h
M Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp
M Source/WebCore/rendering/mathml/RenderMathMLRoot.h
M Source/WebCore/rendering/mathml/RenderMathMLRow.cpp
M Source/WebCore/rendering/mathml/RenderMathMLRow.h
M Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp
M Source/WebCore/rendering/mathml/RenderMathMLScripts.h
M Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp
M Source/WebCore/rendering/mathml/RenderMathMLSpace.h
M Source/WebCore/rendering/mathml/RenderMathMLToken.cpp
M Source/WebCore/rendering/mathml/RenderMathMLToken.h
M Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp
M Source/WebCore/rendering/mathml/RenderMathMLUnderOver.h
Log Message:
-----------
[cleanup] Rename computePreferredLogicalWidths to
computeIntrinsicLogicalWidthContributions
https://bugs.webkit.org/show_bug.cgi?id=315671
Reviewed by Antti Koivisto.
computePreferredLogicalWidths populates m_minPreferredLogicalWidth and
m_maxPreferredLogicalWidth.
These values are the box's min-content / max-content contribution to its
containing block
(per css-sizing-3 ยง4.3 line 323-330: "The size that a box contributes to its
containing block's min-content size", and likewise for max-content).
They are not "preferred" sizes in the spec sense.
The cached members, getters, and dirty-flag still use the
"Preferred" naming for now (m_minPreferredLogicalWidth,
minPreferredLogicalWidth(), needsPreferredLogicalWidthsUpdate(),
etc.).
The unrelated overloaded RenderText::computePreferredLogicalWidths
that takes (float leadWidth, ...) is a different family of functions
on RenderText for text-shaping width computation, and is not renamed here.
No behavior change.
* Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForPreferredWidthComputation):
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderBlock::computePreferredLogicalWidths): Deleted.
* Source/WebCore/rendering/RenderBlock.h:
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::minPreferredLogicalWidth const):
(WebCore::RenderBox::maxPreferredLogicalWidth const):
(WebCore::RenderBox::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderBox::computePreferredLogicalWidths): Deleted.
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths): Deleted.
* Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h:
* Source/WebCore/rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderFileUploadControl::computePreferredLogicalWidths): Deleted.
* Source/WebCore/rendering/RenderFileUploadControl.h:
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeMainAxisExtentForFlexItem):
* Source/WebCore/rendering/RenderFragmentContainer.cpp:
(WebCore::RenderFragmentContainer::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderFragmentContainer::computePreferredLogicalWidths): Deleted.
* Source/WebCore/rendering/RenderFragmentContainer.h:
* Source/WebCore/rendering/RenderListBox.cpp:
(WebCore::RenderListBox::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderListBox::computePreferredLogicalWidths): Deleted.
* Source/WebCore/rendering/RenderListBox.h:
* Source/WebCore/rendering/RenderListItem.cpp:
(WebCore::RenderListItem::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderListItem::computePreferredLogicalWidths): Deleted.
* Source/WebCore/rendering/RenderListItem.h:
* Source/WebCore/rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderListMarker::computePreferredLogicalWidths): Deleted.
* Source/WebCore/rendering/RenderListMarker.h:
* Source/WebCore/rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderMenuList::computePreferredLogicalWidths): Deleted.
* Source/WebCore/rendering/RenderMenuList.h:
* Source/WebCore/rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderReplaced::computePreferredLogicalWidths): Deleted.
* Source/WebCore/rendering/RenderReplaced.h:
* Source/WebCore/rendering/RenderReplica.cpp:
(WebCore::RenderReplica::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderReplica::computePreferredLogicalWidths): Deleted.
* Source/WebCore/rendering/RenderReplica.h:
* Source/WebCore/rendering/RenderSlider.cpp:
(WebCore::RenderSlider::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderSlider::computePreferredLogicalWidths): Deleted.
* Source/WebCore/rendering/RenderSlider.h:
* Source/WebCore/rendering/RenderTable.cpp:
(WebCore::RenderTable::computeIntrinsicLogicalWidths const):
(WebCore::RenderTable::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderTable::computePreferredLogicalWidths): Deleted.
* Source/WebCore/rendering/RenderTable.h:
* Source/WebCore/rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderTableCell::computePreferredLogicalWidths): Deleted.
* Source/WebCore/rendering/RenderTableCell.h:
* Source/WebCore/rendering/RenderTableCol.h:
* Source/WebCore/rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderTextControl::computePreferredLogicalWidths): Deleted.
* Source/WebCore/rendering/RenderTextControl.h:
* Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderMathMLFraction::computePreferredLogicalWidths): Deleted.
* Source/WebCore/rendering/mathml/RenderMathMLFraction.h:
* Source/WebCore/rendering/mathml/RenderMathMLMenclose.cpp:
(WebCore::RenderMathMLMenclose::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderMathMLMenclose::computePreferredLogicalWidths): Deleted.
* Source/WebCore/rendering/mathml/RenderMathMLMenclose.h:
* Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths): Deleted.
* Source/WebCore/rendering/mathml/RenderMathMLOperator.h:
* Source/WebCore/rendering/mathml/RenderMathMLPadded.cpp:
(WebCore::RenderMathMLPadded::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderMathMLPadded::computePreferredLogicalWidths): Deleted.
* Source/WebCore/rendering/mathml/RenderMathMLPadded.h:
* Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderMathMLRoot::computePreferredLogicalWidths): Deleted.
* Source/WebCore/rendering/mathml/RenderMathMLRoot.h:
* Source/WebCore/rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderMathMLRow::computePreferredLogicalWidths): Deleted.
* Source/WebCore/rendering/mathml/RenderMathMLRow.h:
* Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp:
(WebCore::RenderMathMLScripts::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderMathMLScripts::computePreferredLogicalWidths): Deleted.
* Source/WebCore/rendering/mathml/RenderMathMLScripts.h:
* Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp:
(WebCore::RenderMathMLSpace::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderMathMLSpace::computePreferredLogicalWidths): Deleted.
* Source/WebCore/rendering/mathml/RenderMathMLSpace.h:
* Source/WebCore/rendering/mathml/RenderMathMLToken.cpp:
(WebCore::RenderMathMLToken::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderMathMLToken::computePreferredLogicalWidths): Deleted.
* Source/WebCore/rendering/mathml/RenderMathMLToken.h:
* Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderMathMLUnderOver::computePreferredLogicalWidths): Deleted.
* Source/WebCore/rendering/mathml/RenderMathMLUnderOver.h:
Canonical link: https://commits.webkit.org/314036@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
