Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4abb5c4584bfe1807fce4af698b71e447493b8a7
https://github.com/WebKit/WebKit/commit/4abb5c4584bfe1807fce4af698b71e447493b8a7
Author: Mike Wyrzykowski <[email protected]>
Date: 2026-05-28 (Thu, 28 May 2026)
Changed paths:
M Source/WebKit/GPUProcess/graphics/Model/ModelIBLTextures.swift
M Source/WebKit/GPUProcess/graphics/Model/ModelRenderer.swift
M Source/WebKit/GPUProcess/graphics/Model/ModelTypes.h
M Source/WebKit/GPUProcess/graphics/Model/USDModel.swift
M Source/WebKit/GPUProcess/graphics/Model/WebKitMesh.mm
Log Message:
-----------
Reduce async operations in model as they are not really async
https://bugs.webkit.org/show_bug.cgi?id=315638
rdar://178013176
Reviewed by Etienne Segonzac.
There were many places we were would say:
semaphore s;
async_task(f(), [] { s.signal() });
s.wait();
that is not asynchronous. Remove this via calling synchronous versions
of functions.
* Source/WebKit/GPUProcess/graphics/Model/ModelIBLTextures.swift:
* Source/WebKit/GPUProcess/graphics/Model/ModelRenderer.swift:
(Renderer.pendingStandaloneResources):
(Renderer.pendingRendererResources):
(Renderer.createMaterialCompiler(_:)):
(Renderer.createRenderer(_:)):
(Renderer.createMaterialCompiler(_:rasterSampleCount:colorSpace:)): Deleted.
* Source/WebKit/GPUProcess/graphics/Model/ModelTypes.h:
* Source/WebKit/GPUProcess/graphics/Model/USDModel.swift:
(WKBridgeUSDConfiguration.makeStandaloneResources):
(WKBridgeUSDConfiguration.createMaterialCompiler):
(WKBridgeUSDConfiguration.makeRendererResources):
(WKBridgeUSDConfiguration.createRenderer):
(updateMaterial(_:)):
(updateMesh(_:)):
(WKBridgeReceiver.updateMaterial(_:)):
(WKBridgeReceiver.updateMesh(_:)):
* Source/WebKit/GPUProcess/graphics/Model/WebKitMesh.mm:
(WebKit::WebMesh::WebMesh):
(WebKit::WebMesh::update):
(WebKit::WebMesh::updateMaterial):
Canonical link: https://commits.webkit.org/314061@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
