Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f52cdf6cdb19df103de019cf592175aa5b8d2536
https://github.com/WebKit/WebKit/commit/f52cdf6cdb19df103de019cf592175aa5b8d2536
Author: Ahmad Saleem <[email protected]>
Date: 2026-05-28 (Thu, 28 May 2026)
Changed paths:
M LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt
M
LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-presentation-attribute-expected.txt
M
LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
M
LayoutTests/platform/glib/svg/batik/text/textGlyphOrientationHorizontal-expected.txt
M
LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
M
LayoutTests/platform/ios/svg/batik/text/textGlyphOrientationHorizontal-expected.txt
M
LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
M
LayoutTests/platform/mac/svg/batik/text/textGlyphOrientationHorizontal-expected.txt
M LayoutTests/svg/batik/text/textGlyphOrientationHorizontal-expected.txt
M LayoutTests/svg/css/getComputedStyle-basic-expected.txt
M LayoutTests/svg/css/glyph-orientation-rounding-test-expected.txt
M LayoutTests/svg/css/glyph-orientation-rounding-test.xhtml
A LayoutTests/svg/text/glyph-orientation-horizontal-test-expected.txt
A LayoutTests/svg/text/glyph-orientation-horizontal-test.xhtml
M Source/WebCore/Headers.cmake
M Source/WebCore/Sources.txt
M
Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/rendering/svg/SVGTextLayoutEngineBaseline.cpp
M Source/WebCore/style/StyleDifference.cpp
M Source/WebCore/style/computed/StyleComputedStyleBase.h
M
Source/WebCore/style/computed/StyleComputedStyleProperties+InitialCustomInlines.h
M Source/WebCore/style/computed/data/StyleSVGData.cpp
M Source/WebCore/style/computed/data/StyleSVGData.h
R Source/WebCore/style/values/svg/StyleSVGGlyphOrientationHorizontal.cpp
R Source/WebCore/style/values/svg/StyleSVGGlyphOrientationHorizontal.h
M Source/WebCore/svg/SVGElement.cpp
M Source/WebCore/svg/svgattrs.in
Log Message:
-----------
[SVG2] Remove non-standard `glyph-orientation-horizontal`
https://bugs.webkit.org/show_bug.cgi?id=313932
rdar://176134352
Reviewed by Nikolas Zimmermann.
This patch aligns WebKit with Gecko / Firefox, Blink / Chromium and
Web
Specification
[1]:
[1]
https://flagged.apple.com:443/proxy?t2=Dk3F1T0zR1&o=aHR0cHM6Ly93M2MuZ2l0aHViLmlvL3N2Z3dnL3N2ZzItZHJhZnQvdGV4dC5odG1sI0dseXBoT3JpZW50YXRpb25Ib3Jpem9udGFsUHJvcGVydHk=&emid=ae32c917-be12-4e4f-979a-0ae6970cec67&c=11
This was removed from Blink in 2015 as well.
Test: svg/text/glyph-orientation-horizontal-test.xhtml
* LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt:
*
LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-presentation-attribute-expected.txt:
*
LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
*
LayoutTests/platform/glib/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
*
LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
*
LayoutTests/platform/ios/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
*
LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
*
LayoutTests/platform/mac/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
* LayoutTests/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
* LayoutTests/svg/css/getComputedStyle-basic-expected.txt:
* LayoutTests/svg/css/glyph-orientation-rounding-test-expected.txt:
* LayoutTests/svg/css/glyph-orientation-rounding-test.xhtml:
* LayoutTests/svg/text/glyph-orientation-horizontal-test-expected.txt: Added.
*
LayoutTests/svg/text/glyph-orientation-horizontal-test.xhtml: Added.
* Source/WebCore/Headers.cmake:
* Source/WebCore/Sources.txt:
*
Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/rendering/svg/SVGTextLayoutEngineBaseline.cpp:
(WebCore::SVGTextLayoutEngineBaseline::calculateGlyphOrientationAngle const):
(WebCore::SVGTextLayoutEngineBaseline::calculateGlyphAdvanceAndOrientation
const):
* Source/WebCore/style/StyleDifference.cpp:
* Source/WebCore/style/computed/StyleComputedStyleBase.h:
*
Source/WebCore/style/computed/StyleComputedStyleProperties+InitialCustomInlines.h:
(WebCore::Style::ComputedStyleProperties::initialGlyphOrientationHorizontal):
Deleted.
* Source/WebCore/style/computed/data/StyleSVGData.cpp:
(WebCore::Style::SVGData::setBitDefaults):
(WebCore::Style::SVGData::InheritedFlags::dumpDifferences const):
* Source/WebCore/style/computed/data/StyleSVGData.h:
*
Source/WebCore/style/values/svg/StyleSVGGlyphOrientationHorizontal.cpp: Removed.
* Source/WebCore/style/values/svg/StyleSVGGlyphOrientationHorizontal.h: Removed.
*
Source/WebCore/svg/SVGElement.cpp:
(WebCore::SVGElement::cssPropertyIdForSVGAttributeName):
* Source/WebCore/svg/svgattrs.in:
Canonical link:
https://flagged.apple.com:443/proxy?t2=DX5u3z5AQ8&o=aHR0cHM6Ly9jb21taXRzLndlYmtpdC5vcmcvMzE0MDY5QG1haW4=&emid=ae32c917-be12-4e4f-979a-0ae6970cec67&c=11
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications