Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f9873dfa45c5258805950dcda740298335d5f67c
https://github.com/WebKit/WebKit/commit/f9873dfa45c5258805950dcda740298335d5f67c
Author: Sihui Liu <[email protected]>
Date: 2026-05-29 (Fri, 29 May 2026)
Changed paths:
M LayoutTests/http/tests/security/resources/credentials-main-resource.py
R
LayoutTests/http/tests/security/resources/iframe-for-storage-blocking-changed-local-storage.html
R
LayoutTests/http/tests/security/resources/iframe-for-storage-blocking-changed-websql.html
R
LayoutTests/http/tests/security/storage-blocking-loosened-local-storage-expected.txt
R
LayoutTests/http/tests/security/storage-blocking-loosened-local-storage.html
R
LayoutTests/http/tests/security/storage-blocking-loosened-plugin-expected.txt
R
LayoutTests/http/tests/security/storage-blocking-loosened-private-browsing-plugin-expected.txt
R
LayoutTests/http/tests/security/storage-blocking-loosened-websql-expected.txt
R LayoutTests/http/tests/security/storage-blocking-loosened-websql.html
R
LayoutTests/http/tests/security/storage-blocking-strengthened-local-storage-expected.txt
R
LayoutTests/http/tests/security/storage-blocking-strengthened-local-storage.html
R
LayoutTests/http/tests/security/storage-blocking-strengthened-plugin-expected.txt
R
LayoutTests/http/tests/security/storage-blocking-strengthened-private-browsing-plugin-expected.txt
R
LayoutTests/http/tests/security/storage-blocking-strengthened-websql-expected.txt
R LayoutTests/http/tests/security/storage-blocking-strengthened-websql.html
M LayoutTests/platform/wk2/TestExpectations
M Source/WebCore/testing/InternalSettings.cpp
M Source/WebCore/testing/InternalSettings.h
M Source/WebCore/testing/InternalSettings.idl
Log Message:
-----------
Remove internals.settings.setStorageBlockingPolicy
https://bugs.webkit.org/show_bug.cgi?id=315230
rdar://177559927
Reviewed by Per Arne Vollan.
internals.settings.setStorageBlockingPolicy only updates the storage blocking
policy in the current web process. Under
Site Isolation, cross-site subframe processes and the network process do not
receive the policy update, making this API
unreliable for testing. We should deprecate it and update the existing callers
to use different API that will work
under both Site Isolation and non-Site Isolation.
313540@main converted all static-policy tests to use the WebKitTestRunner
header, which propagates the policy to all
processes via WebPreferences. The remaining dynamic policy change tests
(storage-blocking-loosened/strengthened-*)
tested that changing the policy at runtime takes effect immediately, which is
not supported with WKTR header. However,
currently there is no API or SPI allows changing storage blocking policy on an
already-loaded document, so dynamic
policy change is not a scenario that needs test coverage. For the static
behavior these tests verify (i.e. BlockAll
policy blocks storage, AllowAll policy allows storage), it's already covered by
same-origin-storage-blocked.html,
same-origin-websql-blocked.html, and other existing tests. Therefore, this
patch removes the dynamic tests, their helper
files and orphaned plugin expected files altogether with the
internals.settings.setStorageBlockingPolicy API.
* LayoutTests/http/tests/security/resources/credentials-main-resource.py:
*
LayoutTests/http/tests/security/resources/iframe-for-storage-blocking-changed-local-storage.html:
Removed.
*
LayoutTests/http/tests/security/resources/iframe-for-storage-blocking-changed-websql.html:
Removed.
*
LayoutTests/http/tests/security/storage-blocking-loosened-local-storage-expected.txt:
Removed.
* LayoutTests/http/tests/security/storage-blocking-loosened-local-storage.html:
Removed.
*
LayoutTests/http/tests/security/storage-blocking-loosened-plugin-expected.txt:
Removed.
*
LayoutTests/http/tests/security/storage-blocking-loosened-private-browsing-plugin-expected.txt:
Removed.
*
LayoutTests/http/tests/security/storage-blocking-loosened-websql-expected.txt:
Removed.
* LayoutTests/http/tests/security/storage-blocking-loosened-websql.html:
Removed.
*
LayoutTests/http/tests/security/storage-blocking-strengthened-local-storage-expected.txt:
Removed.
*
LayoutTests/http/tests/security/storage-blocking-strengthened-local-storage.html:
Removed.
*
LayoutTests/http/tests/security/storage-blocking-strengthened-plugin-expected.txt:
Removed.
*
LayoutTests/http/tests/security/storage-blocking-strengthened-private-browsing-plugin-expected.txt:
Removed.
*
LayoutTests/http/tests/security/storage-blocking-strengthened-websql-expected.txt:
Removed.
* LayoutTests/http/tests/security/storage-blocking-strengthened-websql.html:
Removed.
* LayoutTests/platform/wk2/TestExpectations:
* Source/WebCore/testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setStorageBlockingPolicy): Deleted.
* Source/WebCore/testing/InternalSettings.h:
* Source/WebCore/testing/InternalSettings.idl:
Canonical link: https://commits.webkit.org/314138@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
