Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5021f999fefdad2d467accbaec86b73268b5942e
https://github.com/WebKit/WebKit/commit/5021f999fefdad2d467accbaec86b73268b5942e
Author: Charlie Wolfe <[email protected]>
Date: 2026-05-29 (Fri, 29 May 2026)
Changed paths:
A
LayoutTests/http/tests/storageAccess/no-gesture-rejection-should-not-grant-storage-access-under-opener.https-expected.txt
A
LayoutTests/http/tests/storageAccess/no-gesture-rejection-should-not-grant-storage-access-under-opener.https.html
A
LayoutTests/http/tests/storageAccess/resources/request-storage-access-without-gesture-and-report-back.html
A
LayoutTests/http/tests/storageAccess/resources/request-storage-access-without-gesture-in-iframe.html
M Source/WebCore/dom/DocumentStorageAccess.cpp
Log Message:
-----------
Don't log interaction from temporary gesture on storage access rejection
https://bugs.webkit.org/show_bug.cgi?id=309504
rdar://171546420
Reviewed by Abrar Rahman Protyasha.
The no-gesture requestStorageAccess() rejection path preserves the user gesture
so callers can still
perform gesture-gated actions like window.open(). However, the temporary
UserGestureIndicator was
created with ProcessInteractionStyle::Immediate, which logged user interaction
as a side effect. In
a popup with an opener, this fabricated interaction triggered
requestStorageAccessUnderOpener(),
silently granting storage access without a prompt.
Pass ProcessInteractionStyle::Never to prevent interaction logging from the
temporary gesture while
still preserving gesture-gated capabilities.
Test:
http/tests/storageAccess/no-gesture-rejection-should-not-grant-storage-access-under-opener.https.html
*
LayoutTests/http/tests/storageAccess/no-gesture-rejection-should-not-grant-storage-access-under-opener.https-expected.txt:
Added.
*
LayoutTests/http/tests/storageAccess/no-gesture-rejection-should-not-grant-storage-access-under-opener.https.html:
Added.
*
LayoutTests/http/tests/storageAccess/resources/request-storage-access-without-gesture-and-report-back.html:
Added.
*
LayoutTests/http/tests/storageAccess/resources/request-storage-access-without-gesture-in-iframe.html:
Added.
* Source/WebCore/dom/DocumentStorageAccess.cpp:
(WebCore::DocumentStorageAccess::enableTemporaryTimeUserGesture):
Originally-landed-as: 305413.463@rapid/safari-7624.2.5.110-branch
(8360fe257449). rdar://176062508
Canonical link: https://commits.webkit.org/314172@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
