Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6fddc62aa92cdbc797ea3679e5da38792661c8b7
https://github.com/WebKit/WebKit/commit/6fddc62aa92cdbc797ea3679e5da38792661c8b7
Author: Alan Baradlay <[email protected]>
Date: 2026-05-29 (Fri, 29 May 2026)
Changed paths:
M
Source/WebCore/layout/integration/LayoutIntegrationFormattingContextLayout.cpp
M Source/WebCore/rendering/AutoTableLayout.cpp
M Source/WebCore/rendering/AutoTableLayout.h
M Source/WebCore/rendering/FixedTableLayout.cpp
M Source/WebCore/rendering/FixedTableLayout.h
M Source/WebCore/rendering/RenderBlock.cpp
M Source/WebCore/rendering/RenderBlock.h
M Source/WebCore/rendering/RenderBlockFlow.cpp
M Source/WebCore/rendering/RenderBlockFlow.h
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp
M Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h
M Source/WebCore/rendering/RenderFileUploadControl.cpp
M Source/WebCore/rendering/RenderFileUploadControl.h
M Source/WebCore/rendering/RenderFlexibleBox.cpp
M Source/WebCore/rendering/RenderFlexibleBox.h
M Source/WebCore/rendering/RenderFragmentContainer.cpp
M Source/WebCore/rendering/RenderFragmentContainer.h
M Source/WebCore/rendering/RenderFrameSet.h
M Source/WebCore/rendering/RenderGrid.cpp
M Source/WebCore/rendering/RenderGrid.h
M Source/WebCore/rendering/RenderListBox.cpp
M Source/WebCore/rendering/RenderListBox.h
M Source/WebCore/rendering/RenderListMarker.h
M Source/WebCore/rendering/RenderMenuList.cpp
M Source/WebCore/rendering/RenderMenuList.h
M Source/WebCore/rendering/RenderMultiColumnSpannerPlaceholder.h
M Source/WebCore/rendering/RenderReplaced.cpp
M Source/WebCore/rendering/RenderReplaced.h
M Source/WebCore/rendering/RenderReplica.h
M Source/WebCore/rendering/RenderSlider.cpp
M Source/WebCore/rendering/RenderSlider.h
M Source/WebCore/rendering/RenderTable.cpp
M Source/WebCore/rendering/RenderTable.h
M Source/WebCore/rendering/RenderTableCol.h
M Source/WebCore/rendering/RenderTableRow.h
M Source/WebCore/rendering/RenderTableSection.h
M Source/WebCore/rendering/RenderTextControl.cpp
M Source/WebCore/rendering/RenderTextControl.h
M Source/WebCore/rendering/TableLayout.h
Log Message:
-----------
[cleanup] Make computeIntrinsicLogicalWidths return std::pair<LayoutUnit,
LayoutUnit> instead of using out-params
https://bugs.webkit.org/show_bug.cgi?id=315678
Reviewed by Antti Koivisto.
computeIntrinsicLogicalWidths and its keyword variant always produce a
(min, max) result that every caller fully assigns, so the out-params only
bought zero-init boilerplate at each call site. Return the pair directly and
let callers use structured bindings or std::tie. RenderGrid's
computeTrackSizesForIndefiniteSize, which feeds those values, gets the same
treatment.
*
Source/WebCore/layout/integration/LayoutIntegrationFormattingContextLayout.cpp:
(WebCore::LayoutIntegration::formattingContextRootLogicalWidthForType):
* Source/WebCore/rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::computeIntrinsicLogicalWidths):
* Source/WebCore/rendering/AutoTableLayout.h:
* Source/WebCore/rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::computeIntrinsicLogicalWidths):
* Source/WebCore/rendering/FixedTableLayout.h:
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeIntrinsicLogicalWidths const):
(WebCore::RenderBlock::computeIntrinsicLogicalWidthContributions):
* Source/WebCore/rendering/RenderBlock.h:
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::computeIntrinsicLogicalWidths const):
* Source/WebCore/rendering/RenderBlockFlow.h:
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::computeIntrinsicKeywordLogicalWidths const):
(WebCore::RenderBox::computeSizingKeywordLogicalWidthUsing const):
(WebCore::RenderBox::computeOutOfFlowPositionedLogicalWidthUsing const):
(WebCore::RenderBox::applyAutomaticContentBasedMinimumSize const):
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::computeIntrinsicLogicalWidths const):
(WebCore::RenderDeprecatedFlexibleBox::computeIntrinsicLogicalWidthContributions):
* Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h:
* Source/WebCore/rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::computeIntrinsicLogicalWidths const):
(WebCore::RenderFileUploadControl::computeIntrinsicLogicalWidthContributions):
* Source/WebCore/rendering/RenderFileUploadControl.h:
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths const):
* Source/WebCore/rendering/RenderFlexibleBox.h:
* Source/WebCore/rendering/RenderFragmentContainer.cpp:
(WebCore::RenderFragmentContainer::computeIntrinsicLogicalWidths const):
(WebCore::RenderFragmentContainer::computeIntrinsicLogicalWidthContributions):
* Source/WebCore/rendering/RenderFragmentContainer.h:
* Source/WebCore/rendering/RenderFrameSet.h:
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeIntrinsicLogicalWidths const):
(WebCore::RenderGrid::computeTrackSizesForIndefiniteSize const):
* Source/WebCore/rendering/RenderGrid.h:
* Source/WebCore/rendering/RenderListBox.cpp:
(WebCore::RenderListBox::computeIntrinsicLogicalWidths const):
(WebCore::RenderListBox::computeIntrinsicLogicalWidthContributions):
* Source/WebCore/rendering/RenderListBox.h:
* Source/WebCore/rendering/RenderListMarker.h:
* Source/WebCore/rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::computeIntrinsicLogicalWidths const):
(WebCore::RenderMenuList::computeIntrinsicLogicalWidthContributions):
* Source/WebCore/rendering/RenderMenuList.h:
* Source/WebCore/rendering/RenderMultiColumnSpannerPlaceholder.h:
* Source/WebCore/rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeIntrinsicLogicalWidths const):
(WebCore::RenderReplaced::computeIntrinsicKeywordLogicalWidths const):
(WebCore::RenderReplaced::computeIntrinsicLogicalWidthContributions):
* Source/WebCore/rendering/RenderReplaced.h:
* Source/WebCore/rendering/RenderReplica.h:
* Source/WebCore/rendering/RenderSlider.cpp:
(WebCore::RenderSlider::computeIntrinsicLogicalWidths const):
(WebCore::RenderSlider::computeIntrinsicLogicalWidthContributions):
* Source/WebCore/rendering/RenderSlider.h:
* Source/WebCore/rendering/RenderTable.cpp:
(WebCore::RenderTable::computeIntrinsicLogicalWidths const):
(WebCore::RenderTable::computeIntrinsicKeywordLogicalWidths const):
(WebCore::RenderTable::computeIntrinsicLogicalWidthContributions):
* Source/WebCore/rendering/RenderTable.h:
* Source/WebCore/rendering/RenderTableCol.h:
* Source/WebCore/rendering/RenderTableRow.h:
* Source/WebCore/rendering/RenderTableSection.h:
* Source/WebCore/rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computeIntrinsicLogicalWidths const):
(WebCore::RenderTextControl::computeIntrinsicLogicalWidthContributions):
* Source/WebCore/rendering/RenderTextControl.h:
* Source/WebCore/rendering/TableLayout.h:
Canonical link: https://commits.webkit.org/314174@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
