Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 530b45dfe35a1904fc48f5d04a7445ad809fd186
https://github.com/WebKit/WebKit/commit/530b45dfe35a1904fc48f5d04a7445ad809fd186
Author: Michael Catanzaro <[email protected]>
Date: 2026-05-30 (Sat, 30 May 2026)
Changed paths:
M Tools/MiniBrowser/gtk/BrowserCellRendererVariant.c
M Tools/MiniBrowser/gtk/CMakeLists.txt
R Tools/MiniBrowser/gtk/browser-marshal.list
Log Message:
-----------
[GTK] Remove MiniBrowser's use of glib-genmarshal
https://bugs.webkit.org/show_bug.cgi?id=315772
Reviewed by Adrian Perez de Castro.
There's only one generated marshaller and it's only used for
BrowserCellRendererVariant::changed. The value of using a custom
marshaller is twofold: it provides a performance boost relative to using
the generic marshaller, and it (somehow?) makes profiling easier. It's
extremely unlikely that anybody is going to profile the performance of
MiniBrowser's settings dialog. Let's just delete the extra complexity.
My goal here is to silence its build spam:
[9495/9573] Generating ../../../MiniBrowser/DerivedSources/BrowserMarshal.c,
../../../MiniBrowser/DerivedSources/BrowserMarshal.h
INFO: Reading
/home/mcatanzaro/Projects/WebKit/Tools/MiniBrowser/gtk/browser-marshal.list...
INFO: Reading
/home/mcatanzaro/Projects/WebKit/Tools/MiniBrowser/gtk/browser-marshal.list...
which could be achieved just as well by passing --quiet to the command.
I just don't see value in keeping it.
* Tools/MiniBrowser/gtk/BrowserCellRendererVariant.c:
(browser_cell_renderer_variant_class_init):
* Tools/MiniBrowser/gtk/CMakeLists.txt:
* Tools/MiniBrowser/gtk/browser-marshal.list: Removed.
Canonical link: https://commits.webkit.org/314211@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
