Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a7a679e01341a0a578161a2471b076e61118a88a
https://github.com/WebKit/WebKit/commit/a7a679e01341a0a578161a2471b076e61118a88a
Author: Vitor Roriz <[email protected]>
Date: 2026-06-01 (Mon, 01 Jun 2026)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-variant-serialization-expected.txt
M Source/WebCore/css/ShorthandSerializer.cpp
Log Message:
-----------
Serialize explicit font-variant longhands set after a system font
https://bugs.webkit.org/show_bug.cgi?id=315853
rdar://178251443
Reviewed by Darin Adler.
font: <system-font> (e.g. menu) stamps every font-variant longhand with a
system-font sentinel keyword, for example, font-variant-numeric: menu.
ShorthandSerializer::serializeFontVariant currently returns
the empty string whenever any longhand held that sentinel, so an explicitly-set
longhand such as font-variant-numeric: tabular-nums was dropped from the
shorthand. Therefore only return empty when all longhands are system-font
sentinels, otherwise omit the sentinels and serialize the rest.
This is what the font-variant-serialization WPT asserts and and other
major engines follow.
* Source/WebCore/css/ShorthandSerializer.cpp:
(WebCore::ShorthandSerializer::serializeFontVariant const):
*
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-variant-serialization-expected.txt:
Canonical link: https://commits.webkit.org/314292@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
