Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 24c7fd849044cd54b2bba1b20aa93197ee0b2f04
https://github.com/WebKit/WebKit/commit/24c7fd849044cd54b2bba1b20aa93197ee0b2f04
Author: Carlos Alberto Lopez Perez <[email protected]>
Date: 2026-06-03 (Wed, 03 Jun 2026)
Changed paths:
M Tools/CISupport/build-webkit-org/config.json
M Tools/CISupport/build-webkit-org/factories.py
M Tools/CISupport/build-webkit-org/factories_unittest.py
Log Message:
-----------
[build.webkit.org][GTK][WPE] Remove all Debug bots except the ones that run
layout tests, also remove the SDK bots and add a Builder for GTK perf.
https://bugs.webkit.org/show_bug.cgi?id=316149
Reviewed by Nikolas Zimmermann.
Since we enabled assertions on release post-commit bots around 313986@main
there is no value in running
tests in Debug unless the test suite is able to generate backtraces (because
Debug builds are less
optimized so the backtraces read better).
And currently the only test suite that is able to generate backtraces is layout
tests (run-webkit-tests).
All the other test suites just ignore any crash if it happens (they may report
that webkit crashed, but
they are not able to generate or report any info about backtraces or any crash
log).
So given that status quo, it makes sense that we drop all testing in Debug but
layout tests.
Release tests already cover assertions (we enable those now by default), and
Debug tests can't generate
backtraces: so no value on running debug tests.
This means we can optimize this further and merge the Debug build with the
Debug layout test bot, so we
don't longer need to pass 5GB built products all over internet (Amazon S3) and
we can keep everything
local. This also will help to avoid issues related to webkit.org/b/304213
This patch removes all the WPE and GTK Debug bots except two (one for each
port), and that remaining bot
is set to build and run layout tests. To avoid disrupting external tools
(webkit-testhunter, etc) the
name and the bot-id of the bot remains the one of the previous bot that was
running the layout tests for
Debug.
This patch also seizes this to remove the deprecated SDK bots (we stopped
running those quite ago), and
adds a GTK perf build bot for the GTK perf bot: We tried to switch the machine
to build its own built
products on 312685@main but the machine is not powerful enough to build webkit
and keeps having issues.
So add a builder that doesn't enable assertions for it.
Important: use a unique platform suffix ("gtk-perf") so the build products from
this builder have a unique
path and don't collide with the built-products from default release gtk bot
that enables assertions
(so do not repeat the mistake fixed on 308273@main).
Add also some unit tests for this to catch the issue early next time.
* Tools/CISupport/build-webkit-org/config.json:
* Tools/CISupport/build-webkit-org/factories.py:
(BuildAndTestAllButJSCFactory):
(BuildAndTestAndArchiveAllButJSCFactory): Deleted.
(BuildAndTestAndArchiveAllButJSCFactory.__init__): Deleted.
* Tools/CISupport/build-webkit-org/factories_unittest.py:
(TestExpectedBuildSteps):
(TestExpectedBuildSteps.test_unnecessary_expected_steps):
(TestExpectedBuildSteps.test_unique_platform_for_build_product_upload):
(TestExpectedBuildSteps.test_triggered_testers_share_builder_platform):
(TestExpectedBuildSteps.test_all_builders_are_reachable_by_a_scheduler):
Canonical link: https://commits.webkit.org/314466@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
