Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 97f9aa683f1084fe7cfa68d50ce1bf4ba2cf77df
https://github.com/WebKit/WebKit/commit/97f9aa683f1084fe7cfa68d50ce1bf4ba2cf77df
Author: Dawn Morningstar <[email protected]>
Date: 2026-06-03 (Wed, 03 Jun 2026)
Changed paths:
M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/mocks/__init__.py
M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/partial_proxy.py
M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/timeout.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
M Tools/Scripts/webkitpy/common/version_name_map.py
M
Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_legacy.py
M Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
M Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
M Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py
M Tools/Scripts/webkitpy/port/base.py
M Tools/Scripts/webkitpy/port/base_unittest.py
M Tools/Scripts/webkitpy/port/config.py
M Tools/Scripts/webkitpy/port/config_unittest.py
M Tools/Scripts/webkitpy/port/darwin.py
M Tools/Scripts/webkitpy/port/factory.py
M Tools/Scripts/webkitpy/port/factory_unittest.py
M Tools/Scripts/webkitpy/port/mac.py
Log Message:
-----------
reland and fix 314080@main for iOS tests
https://bugs.webkit.org/show_bug.cgi?id=316023
rdar://178452196
Reviewed by Jonathan Bedard.
Relands 314080@main (https://bugs.webkit.org/show_bug.cgi?id=314459) together
with the iOS layout-test fix it needs. The original commit moved
configuration_for_upload(target_host(0)) to after _run_test_subset, but
_run_test_subset's finally calls clean_up_test_run, which on iOS deletes the
simulator. target_host(0) afterwards raises 'No initialized devices for
testing' and breaks every iOS layout-test bot. Capture the upload configuration
before _run_test_subset; keep the if self._options.report_urls gate so the
requests import-cost optimization is preserved. Adds an integration regression
test that simulates the iOS device-teardown invariant.
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/mocks/__init__.py:
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/partial_proxy.py:
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/timeout.py:
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py:
* Tools/Scripts/webkitpy/common/version_name_map.py:
* Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_legacy.py:
(LayoutTestFinder.__init__):
(LayoutTestFinder._make_inner_finder):
(LayoutTestFinder.find_tests_by_path):
(LayoutTestFinder._is_test_file):
(LayoutTestFinder._is_w3c_resource_file):
* Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run):
(Manager._set_up_run):
(Manager._update_worker_count):
(Manager._end_test_run):
* Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser._tokenize_line):
* Tools/Scripts/webkitpy/port/base.py:
(Port._helper_process):
(Port._helper_started):
(Port._helper_ready):
(Port.start_helper_async):
(Port.wait_for_helper_ready):
(Port.stop_helper):
* Tools/Scripts/webkitpy/port/config.py:
(Config._build_directories):
(Config._clear_cache_for_testing):
(Config.build_directory):
* Tools/Scripts/webkitpy/port/base_unittest.py:
* Tools/Scripts/webkitpy/port/config_unittest.py:
(PortTest.setUp):
(ConfigTest.setUp):
* Tools/Scripts/webkitpy/port/darwin.py:
(DarwinPort.CURRENT_VERSION):
* Tools/Scripts/webkitpy/port/factory.py:
(_load_port_class):
(PortFactory.PORT_CLASSES):
(PortFactory.get):
(configuration_options):
* Tools/Scripts/webkitpy/port/factory_unittest.py:
(FactoryTest.test_port_classes_table_consistency):
* Tools/Scripts/webkitpy/port/mac.py:
(MacPort.setup_test_run):
(MacPort.start_helper):
(MacPort.start_helper_async):
(MacPort.wait_for_helper_ready):
* Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest.test_target_host_available_when_capturing_upload_configuration):
Co-authored-by: Alexey Proskuryakov <[email protected]>
Canonical link: https://commits.webkit.org/314474@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
