Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8d287629f85e4c16e63d102e2b74f66c66f54e67
https://github.com/WebKit/WebKit/commit/8d287629f85e4c16e63d102e2b74f66c66f54e67
Author: Zak Ridouh <[email protected]>
Date: 2026-06-03 (Wed, 03 Jun 2026)
Changed paths:
M Source/WebKitLegacy/PlatformCocoa.cmake
M Source/cmake/OptionsCocoa.cmake
M Tools/DumpRenderTree/PlatformMac.cmake
M Tools/ImageDiff/PlatformMac.cmake
M Tools/MiniBrowser/mac/CMakeLists.txt
Log Message:
-----------
[CMake] Enable -Wunused-parameter on Cocoa to match Xcode
https://bugs.webkit.org/show_bug.cgi?id=316129
rdar://178557623
Reviewed by Pascoe.
The Cocoa CMake build globally suppressed -Wunused-parameter via
-Wno-unused-parameter in OptionsCocoa.cmake, even though -Wall -Wextra
already enables it. Xcode enables the warning everywhere (-Wextra in
CommonBase.xcconfig, treated as an error) and opts specific projects out
per-target via WK_FIXME_WARNING_CFLAGS.
Drop the blanket suppression so WTF, JavaScriptCore, WebCore, and PAL
warn like they do under Xcode, and add per-target opt-outs mirroring the
projects Xcode still exempts: WebKit (already present), WebKitLegacy,
DumpRenderTree, ImageDiff, and MiniBrowser. TestWebKitAPI and
WebKitTestRunner already opt out; the third-party targets build with -w.
WebKitLegacy's existing opt-out used add_compile_options(), which runs
after WEBKIT_FRAMEWORK_DECLARE creates the target and so never applied;
switch it to the target-scoped WEBKIT_ADD_TARGET_CXX_FLAGS form.
* Source/WebKitLegacy/PlatformCocoa.cmake:
* Source/cmake/OptionsCocoa.cmake:
* Tools/DumpRenderTree/PlatformMac.cmake:
* Tools/ImageDiff/PlatformMac.cmake:
* Tools/MiniBrowser/mac/CMakeLists.txt:
Canonical link: https://commits.webkit.org/314510@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
