Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5f563512b5c64f92104fedc8ecf373518c2a14ee
https://github.com/WebKit/WebKit/commit/5f563512b5c64f92104fedc8ecf373518c2a14ee
Author: Abrar Rahman Protyasha <[email protected]>
Date: 2026-06-03 (Wed, 03 Jun 2026)
Changed paths:
M
LayoutTests/media/modern-media-controls/icon-service/icon-service-bundle-load.html
M LayoutTests/platform/mac-wk2/TestExpectations
M LayoutTests/resources/ui-helper.js
Log Message:
-----------
media/modern-media-controls/icon-service/icon-service-bundle-load.html is a
flaky text failure
https://bugs.webkit.org/show_bug.cgi?id=316020
rdar://178452109
Reviewed by Tim Horton and Megan Gardner.
This test checked the media control icons after a single rAF, but since
the icons were loaded into `blob: URL` <img>s, they were only committed in
some future rendering update.
To address the flakiness, we wait until at least one icon has committed
a `blob:` mask-image. We bound the wait till 120 frames so as to not
time out in the failing case. To support this test change, we add an
optional maximumFrames argument to the waitForCondition methods in
UIHelper.
*
LayoutTests/media/modern-media-controls/icon-service/icon-service-bundle-load.html:
* LayoutTests/platform/mac-wk2/TestExpectations:
* LayoutTests/resources/ui-helper.js:
(window.UIHelper.async waitForCondition):
(window.UIHelper.async waitForConditionAsync):
Canonical link: https://commits.webkit.org/314519@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
