Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c4104fee97014ee644f68172798c46248d542115
https://github.com/WebKit/WebKit/commit/c4104fee97014ee644f68172798c46248d542115
Author: Chris Dumez <[email protected]>
Date: 2026-06-04 (Thu, 04 Jun 2026)
Changed paths:
M Source/WebCore/platform/cocoa/SerializedPlatformDataCueValue.mm
Log Message:
-----------
SerializedPlatformDataCueValue::operator== is non-reflexive for
default-constructed values
https://bugs.webkit.org/show_bug.cgi?id=316170
Reviewed by Jean-Yves Avenard.
SerializedPlatformDataCueValue::operator== returned false whenever either
operand had no underlying Data (i.e. was constructed from a nil
AVMetadataItem or default-constructed). As a result, two empty cue values
compared unequal — including a value compared against itself — violating
the basic reflexivity invariant of equality and breaking any change
detection that relied on operator== for the empty case.
Defer to std::optional<Data>'s built-in operator==, which correctly
returns true when both sides are nullopt, false when exactly one is, and
otherwise compares the wrapped Data via Data::operator==.
* Source/WebCore/platform/cocoa/SerializedPlatformDataCueValue.mm:
(WebCore::SerializedPlatformDataCueValue::operator== const):
Canonical link: https://commits.webkit.org/314542@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
