Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 84cc8da54379edcc790cb9453a9d83699bffc83f
https://github.com/WebKit/WebKit/commit/84cc8da54379edcc790cb9453a9d83699bffc83f
Author: Alan Baradlay <[email protected]>
Date: 2026-06-04 (Thu, 04 Jun 2026)
Changed paths:
M Source/WebCore/dom/Document.cpp
M Source/WebCore/rendering/RenderBlock.cpp
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBox.h
Log Message:
-----------
Clean up legacy "preferred width" naming in RenderBox intrinsic width sizing
helpers
https://bugs.webkit.org/show_bug.cgi?id=316309
Reviewed by Antti Koivisto.
These two RenderBox helpers used the old CSS 2.1 "preferred width" vocabulary.
The CSS Sizing spec renamed it long ago: "preferred width" became max-content
and "preferred minimum width" became min-content, and the intrinsic-width pair
is already spelled min/maxContentLogicalWidthContribution here. "Fit content"
was never the stale part; it is the current term for what CSS 2.1 called
shrink-to-fit.
sizesPreferredLogicalWidthToFitContent() drops the redundant "Preferred" to
become sizesLogicalWidthToFitContent().
shouldComputePreferredLogicalWidthsFromStyle()
had a single caller inside constrainIntrinsicLogicalWidthsByMinMax() and named
the now-renamed intrinsic widths, so it is inlined there as a local
hasFixedLogicalWidth check. No behavior change.
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::updateLayoutIfDimensionsOutOfDate):
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::relayoutRenderBlockForScrollbarChange):
(WebCore::sizesAffectedByScrollbarsForSubtreeRoot):
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidthUsingGeneric):
(WebCore::RenderBox::sizesLogicalWidthToFitContent):
(WebCore::RenderBox::constrainIntrinsicLogicalWidthsByMinMax):
(WebCore::RenderBox::shouldComputePreferredLogicalWidthsFromStyle): Deleted.
* Source/WebCore/rendering/RenderBox.h:
Canonical link: https://commits.webkit.org/314553@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
