Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b7a7dec11368575406a43983320f48067ad8f17b
https://github.com/WebKit/WebKit/commit/b7a7dec11368575406a43983320f48067ad8f17b
Author: Ruthvik Konda <[email protected]>
Date: 2026-06-04 (Thu, 04 Jun 2026)
Changed paths:
M Source/WebCore/Modules/model-element/HTMLModelElement.cpp
M Source/WebCore/Modules/model-element/dummy/DummyModelPlayer.cpp
Log Message:
-----------
Reduce use of `.get()` for smart pointers in model element code
https://bugs.webkit.org/show_bug.cgi?id=316283
rdar://178691695
Reviewed by Etienne Segonzac.
`RefPtr<T>` has a constructor that takes `WeakPtr<T>` directly (RefPtr.h:104),
calling `.get()` internally. Removing redundant `.get()` calls at ten sites
across two files in `Source/WebCore/Modules/model-element/` simplifies the
code without changing behavior — the constructor invokes `.get()` itself.
For the five statement-form `RefPtr` initializations from `WeakPtr`, also
switched from copy-init (`=`) to brace-init (`{}`) per current WebKit style.
No new tests needed (no behavioral change).
* Source/WebCore/Modules/model-element/HTMLModelElement.cpp:
(WebCore::HTMLModelElement::HTMLModelElement):
(WebCore::HTMLModelElement::didFinishLoading):
(WebCore::HTMLModelElement::createModelPlayer):
(WebCore::HTMLModelElement::deleteModelPlayer):
(WebCore::HTMLModelElement::deletePendingModelPlayer):
(WebCore::HTMLModelElement::reloadModelPlayer):
(WebCore::HTMLModelElement::ensureImmersivePresentation):
(WebCore::HTMLModelElement::exitImmersivePresentation):
* Source/WebCore/Modules/model-element/dummy/DummyModelPlayer.cpp:
(WebCore::DummyModelPlayer::load):
Canonical link: https://commits.webkit.org/314559@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
