Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 71d209b013ded1e0a01a79eb77cb4307e1d33f92
https://github.com/WebKit/WebKit/commit/71d209b013ded1e0a01a79eb77cb4307e1d33f92
Author: Elliott Williams <[email protected]>
Date: 2026-06-04 (Thu, 04 Jun 2026)
Changed paths:
M Source/WTF/CMakeLists.txt
A Source/cmake/FindICU.cmake
M Source/cmake/OptionsCommon.cmake
M Source/cmake/WebKitCommon.cmake
R Source/cmake/WebKitFindPackage.cmake
M Source/cmake/WebKitXcrun.cmake
Log Message:
-----------
[CMake] Fix ICU finding on Apple platforms and work towards internal SDK
support
https://bugs.webkit.org/show_bug.cgi?id=316332
Reviewed by Geoffrey Garen, Zak Ridouh, and Keith Miller.
Simplify the existing ICU search logic and fix some errors in how Apple
ports mix internal content with WebKit's vendored copy of ICU headers.
The CMake build now matches the Xcode build:
- Builds for an internal SDK use system-provided ICU headers in
./usr/local/include/unicode
- Builds for a public SDK use the vendored copy of ICU headers in
Source/WTF/unicode
Remove our magical find_package macro that has special behavior when
finding ICU. In its place, add a custom FindICU module that impelements
the above on Apple platforms and falls back to the CMake-provided
FindICU on other ports.
Add a new USE_APPLE_INTERNAL_SDK variable, that will be used elsewhere
to manage differences the internal and public SDK build configurations.
* Source/WTF/CMakeLists.txt:
* Source/cmake/FindICU.cmake: Added.
* Source/cmake/OptionsCommon.cmake:
* Source/cmake/WebKitCommon.cmake:
* Source/cmake/WebKitFindPackage.cmake: Removed.
* Source/cmake/WebKitXcrun.cmake:
Canonical link: https://commits.webkit.org/314571@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
