Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f219b0a165b61af02e4e6b31e2fc8b2acbb19387
https://github.com/WebKit/WebKit/commit/f219b0a165b61af02e4e6b31e2fc8b2acbb19387
Author: Matthew Finkel <[email protected]>
Date: 2026-06-04 (Thu, 04 Jun 2026)
Changed paths:
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/Navigation.mm
Log Message:
-----------
"Non-secure site connections" error page blocks localhost with no option to
proceed
https://bugs.webkit.org/show_bug.cgi?id=284559
rdar://141532147
Reviewed by Alex Christensen.
When HTTPSOnly (UserMediatedHTTPFallback) was implemented, we decided that
localhost and loopback connections should not be automatically upgraded.
Unfortunately, at some point we introduced a bug where the interstitial is not
shown for those navigations. Instead, we show the default error page that is a
bad experience.
This patch fixes the issue by ensuring we show the interstitial for the cases
where the URL has the http: scheme and the load failed due to a HTTPSOnly
error.
Test: Tools/TestWebKitAPI/Tests/WebKit/WKWebView/Navigation.mm
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didFailProvisionalLoadForFrameShared):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/Navigation.mm:
(TEST(WKNavigation, HTTPSOnlyLocalHostIPAddress)):
Canonical link: https://commits.webkit.org/314584@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
