Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1457fd953016e6768e2919edad68e34aadef8a7f
https://github.com/WebKit/WebKit/commit/1457fd953016e6768e2919edad68e34aadef8a7f
Author: Geoffrey Garen <[email protected]>
Date: 2026-06-04 (Thu, 04 Jun 2026)
Changed paths:
M Source/JavaScriptCore/Sources.txt
M Source/WTF/Scripts/generate-unified-source-bundles.py
M Source/WTF/wtf/ObjCRuntimeExtras.h
M Source/WTF/wtf/spi/cocoa/objcSPI.h
M Source/WebCore/Sources.txt
M Source/WebCore/SourcesCocoa.txt
M Source/WebCore/accessibility/mac/AXObjectCacheMac.mm
M Source/WebCore/bridge/objc/objc_runtime.mm
M Source/WebCore/platform/cocoa/SearchPopupMenuCocoa.mm
M
Source/WebCore/platform/graphics/avfoundation/objc/AVOutputDeviceMenuControllerTargetPicker.mm
M
Source/WebCore/platform/graphics/avfoundation/objc/AVRoutePickerViewTargetPicker.mm
M
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm
M Source/WebCore/platform/mac/PlaybackSessionInterfaceMac.mm
M Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp
M Source/WebKit/Sources.txt
M Source/WebKit/SourcesCocoa.txt
Log Message:
-----------
[CMake][Mac] Purge most @no-unify
https://bugs.webkit.org/show_bug.cgi?id=316269
rdar://178680121
Reviewed by Zak Ridouh, Mike Wyrzykowski, Brandon Stewart, and Pascoe.
~3% clean build speedup.
With jumbo unified sources, most @no-unify is pessimization.
* Source/JavaScriptCore/Sources.txt: Replace @no-unify with
@no-unify-when(bundle<=8). This avoids a compile time regression in Xcode, where
bundle member count is 8. Add @cost where needed to avoid long pole bundles.
* Source/WTF/Scripts/generate-unified-source-bundles.py: Parsing for the new
@no-unify-when(bundle<= syntax.
(SourceFile.__init__):
* Source/WTF/wtf/ObjCRuntimeExtras.h:
* Source/WTF/wtf/spi/cocoa/objcSPI.h: ::-qualify objc runtime types so a
bundle-mate's file-scope `using namespace JSC::Bindings` cannot make
Method/Class/Protocol ambiguous.
* Source/WebCore/Sources.txt: Replace @no-unify with @no-unify-when(bundle<=8).
(See above.)
* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/accessibility/mac/AXObjectCacheMac.mm: Return NSNumber *
instead of
a typdef name because the global CF_ENUM and our WebCore:: type of the same
name conflict,
and anyway the caller wants an NSNumber *.
(platformChangeTypeForWebCoreChangeType):
(platformEditTypeForWebCoreEditType):
(platformDirectionForWebCoreDirection):
(platformGranularityForWebCoreGranularity):
(WebCore::AXObjectCache::postTextSelectionChangePlatformNotification):
(WebCore::AXObjectCache::postUserInfoForChanges):
* Source/WebCore/platform/cocoa/SearchPopupMenuCocoa.mm: Use a more specific
name to avoid a conflict with another file.
* Source/WebCore/bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcArray::valueAt const): Cast to a more specific type to
avoid ambiguity about which selector declaration we're going to invoke
(-Wobjc-multiple-method-names).
(WebCore::searchPopupWallTimeFromNSDate):
(WebCore::loadRecentSearchesFromFile):
(WebCore::toSystemClockTime): Deleted.
*
Source/WebCore/platform/graphics/avfoundation/objc/AVOutputDeviceMenuControllerTargetPicker.mm:
*
Source/WebCore/platform/graphics/avfoundation/objc/AVRoutePickerViewTargetPicker.mm:
*
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:
* Source/WebCore/platform/mac/PlaybackSessionInterfaceMac.mm: Guard soft-linking
to avoid conflicts when more than one file soft-links.
* Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp: Undef
MESSAGE_CHECK_WITH_RETURN_VALUE like our other macros, to avoid a name conflict.
* Source/WebKit/Sources.txt: Replace @no-unify with @no-unify-when(bundle<=8).
(See above.)
* Source/WebKit/SourcesCocoa.txt:
Canonical link: https://commits.webkit.org/314596@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
